QTFred: Ship Editor Modernization 2 Part 2 (#7026)

* Switch to using signals/slots rather than connect

* Adds coloured persona box

Adds coloured persona box/ fixes persona loading, and reduces amount of data reset on model change

* Update To new flags widget

Updates To new flags widget this reqires moving several non flag items to other dialogs, which also lead to adding a new feature that lets a custom guardian threshold be set in editor

* Switch to size_t

* Make Mission Spec work with changes to Flaglist

* Remove Duplicate member

* Clang Appeasement

* Make static

* Properly initialise guardian threshold

* Convert Player Orders dialog to Checklist box

Unfortunately also formats Shipeditordialogmodel

* Update Custom warp to modern style

* Update Initial status to modern style

* Missed a file

* Update Ship Flags Closing

* Remove QT Code from model

* Update Ship Goals Closing

* Update Special Stats Closing

* Minor Changes

* Replace Paths Dialog With generic checkbox dialog

* Update Texture Replace to modern style

* Cast to int

* Initialize then append

* Clang Fixes

* Two didn't save

* More Clang

* Tighten NOLINT's

* Remove dead code

* Change to built in buttons

Author: TheForce172

code/mission/missionparse.cpp

@@ -3537,8 +3537,8 @@ int parse_object(mission *pm, int  /*flag*/, p_object *p_objp)
         stuff_int(&p_objp->escort_priority);
     }
 
-	if (optional_string("+Guardian Threshold:")) {
-
+	if (optional_string("+Guardian Threshold:")) 
+	{
 		stuff_int(&p_objp->ship_guardian_threshold);
 	} else {
 		if (p_objp->flags[Mission::Parse_Object_Flags::SF_Guardian]) {

qtfred/source_groups.cmake

@@ -110,8 +110,6 @@ add_file_folder("Source/Mission/Dialogs/ShipEditor"
 	src/mission/dialogs/ShipEditor/ShipGoalsDialogModel.cpp
 	src/mission/dialogs/ShipEditor/ShipFlagsDialogModel.cpp
 	src/mission/dialogs/ShipEditor/ShipFlagsDialogModel.h
-	src/mission/dialogs/ShipEditor/PlayerOrdersDialogModel.h
-	src/mission/dialogs/ShipEditor/PlayerOrdersDialogModel.cpp
 	src/mission/dialogs/ShipEditor/ShipSpecialStatsDialogModel.h
 	src/mission/dialogs/ShipEditor/ShipSpecialStatsDialogModel.cpp
 	src/mission/dialogs/ShipEditor/ShipTextureReplacementDialogModel.h
@@ -122,8 +120,6 @@ add_file_folder("Source/Mission/Dialogs/ShipEditor"
 	src/mission/dialogs/ShipEditor/ShipWeaponsDialogModel.h
 	src/mission/dialogs/ShipEditor/WeaponsTBLViewerModel.cpp
 	src/mission/dialogs/ShipEditor/WeaponsTBLViewerModel.h
-	src/mission/dialogs/ShipEditor/ShipPathsDialogModel.cpp
-	src/mission/dialogs/ShipEditor/ShipPathsDialogModel.h
 	src/mission/dialogs/ShipEditor/ShipCustomWarpDialogModel.h
 	src/mission/dialogs/ShipEditor/ShipCustomWarpDialogModel.cpp
 	src/mission/dialogs/ShipEditor/ShipAltShipClassModel.h
@@ -212,8 +208,6 @@ add_file_folder("Source/UI/Dialogs/ShipEditor"
 	src/ui/dialogs/ShipEditor/ShipGoalsDialog.h
 	src/ui/dialogs/ShipEditor/ShipFlagsDialog.h
 	src/ui/dialogs/ShipEditor/ShipFlagsDialog.cpp
-	src/ui/dialogs/ShipEditor/PlayerOrdersDialog.h
-	src/ui/dialogs/ShipEditor/PlayerOrdersDialog.cpp
 	src/ui/dialogs/ShipEditor/ShipSpecialStatsDialog.cpp
 	src/ui/dialogs/ShipEditor/ShipSpecialStatsDialog.h
 	src/ui/dialogs/ShipEditor/ShipTextureReplacementDialog.h
@@ -224,8 +218,6 @@ add_file_folder("Source/UI/Dialogs/ShipEditor"
 	src/ui/dialogs/ShipEditor/ShipWeaponsDialog.h
 	src/ui/dialogs/ShipEditor/BankModel.cpp
 	src/ui/dialogs/ShipEditor/BankModel.h
-	src/ui/dialogs/ShipEditor/ShipPathsDialog.h
-	src/ui/dialogs/ShipEditor/ShipPathsDialog.cpp
 	src/ui/dialogs/ShipEditor/ShipCustomWarpDialog.h
 	src/ui/dialogs/ShipEditor/ShipCustomWarpDialog.cpp
 	src/ui/dialogs/ShipEditor/ShipAltShipClass.h
@@ -308,10 +300,8 @@ add_file_folder("UI"
 	ui/ShipGoalsDialog.ui
 	ui/ShipSpecialStatsDialog.ui
 	ui/ShipFlagsDialog.ui
-	ui/PlayerOrdersDialog.ui
 	ui/ShipTextureReplacementDialog.ui
 	ui/ShipTBLViewer.ui
-	ui/ShipPathsDialog.ui
 	ui/ShipCustomWarpDialog.ui
 	ui/ShipAltShipClass.ui
 	ui/ShipWeaponsDialog.ui