Merge pull request #5870 from Goober5000/any_wingman_check

add a new check to the Voice Acting Manager

Author: Goober5000

fred2/fred.rc

@@ -2179,12 +2179,12 @@ BEGIN
     PUSHBUTTON      "Global Affected-By-Gravity",IDC_AFFECTED_BY_GRAVITY,7,58,100,14
 END
 
-IDD_VOICE_MANAGER DIALOGEX 0, 0, 407, 250
+IDD_VOICE_MANAGER DIALOGEX 0, 0, 407, 284
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU
 CAPTION "Voice Acting Manager"
 FONT 8, "MS Sans Serif", 0, 0, 0x0
 BEGIN
-    GROUPBOX        "File Name Options",IDC_FILE_NAME_OPTIONS,7,7,130,237
+    GROUPBOX        "File Name Options",IDC_FILE_NAME_OPTIONS,7,7,130,271
     GROUPBOX        "Abbreviations",IDC_ABBREVIATIONS,12,17,120,101
     LTEXT           "Campaign",IDC_LBL_ABBREV_CAMPAIGN,17,28,58,10
     EDITTEXT        IDC_ABBREV_CAMPAIGN,82,27,44,12,ES_AUTOHSCROLL
@@ -2208,7 +2208,7 @@ BEGIN
     CONTROL         "Don't replace existing file names",IDC_NO_REPLACE,
                     "Button",BS_AUTOCHECKBOX | WS_TABSTOP,14,186,116,10
     PUSHBUTTON      "Generate File Names",IDC_GENERATE_FILE_NAMES,12,200,120,14
-    GROUPBOX        "Script Options",IDC_SCRIPT_OPTIONS,143,7,257,237
+    GROUPBOX        "Script Options",IDC_SCRIPT_OPTIONS,143,7,257,271
     GROUPBOX        "Script Entry Format",IDC_ENTRY,149,17,246,101
     EDITTEXT        IDC_ENTRY_FORMAT,154,28,109,83,ES_MULTILINE | ES_AUTOHSCROLL | ES_WANTRETURN
     LTEXT           "Placeholder - this text is set at runtime",IDC_ENTRY_FORMAT_DESC,270,28,120,85
@@ -2219,14 +2219,15 @@ BEGIN
     CONTROL         "Just Briefings",IDC_EXPORT_BRIEFINGS,"Button",BS_AUTORADIOBUTTON,280,151,99,9
     CONTROL         "Just Debriefings",IDC_EXPORT_DEBRIEFINGS,"Button",BS_AUTORADIOBUTTON,280,161,99,9
     CONTROL         "Just Messages",IDC_EXPORT_MESSAGES,"Button",BS_AUTORADIOBUTTON,280,171,99,9
-    PUSHBUTTON      "Generate Script",IDC_GENERATE_SCRIPT,275,208,120,30
+    PUSHBUTTON      "Generate Script",IDC_GENERATE_SCRIPT,275,242,120,30
     CONTROL         "Group send-message-list messages before others",IDC_GROUP_MESSAGES,
                     "Button",BS_AUTOCHECKBOX | BS_TOP | BS_MULTILINE | WS_TABSTOP,293,182,100,19
-    GROUPBOX        "Sync Personas",IDC_SYNC_PERSONAS,149,121,119,118
+    GROUPBOX        "Sync Personas",IDC_SYNC_PERSONAS,149,121,119,152
     PUSHBUTTON      "Copy message personas to ships",IDC_MESSAGE_PERSONAS_TO_SHIPS,154,151,109,14
     PUSHBUTTON      "Copy ship personas to messages",IDC_SHIP_PERSONAS_TO_MESSAGES,154,168,109,14
     PUSHBUTTON      "Set head ANIs using personas in messages.tbl",IDC_SET_HEAD_ANIS_USING_MESSAGES_TBL,154,211,109,23,BS_MULTILINE
     PUSHBUTTON      "Clear personas from ships that don't send messages",IDC_CLEAR_PERSONAS_FROM_NON_SENDERS,154,185,109,23,BS_MULTILINE
+    PUSHBUTTON      "Check if messages sent by \x22<any wingman>\x22 have at least one ship with that persona",IDC_CHECK_ANY_WINGMAN_PERSONAS,154,237,109,31,BS_MULTILINE
     LTEXT           "NOTE: Only wingman personas are modified here.",IDC_LBL_NOTE,155,132,107,16
 END
 

fred2/resource.h

@@ -333,6 +333,7 @@
 #define IDC_SPIN6                       1066
 #define IDC_SET_HEAD_ANIS_USING_MESSAGES_TBL 1066
 #define IDC_CLEAR_PERSONAS_FROM_NON_SENDERS 1067
+#define IDC_CHECK_ANY_WINGMAN_PERSONAS  1068
 #define ID_SHOW_FIGHTERS                1071
 #define IDC_PRIORITY7                   1071
 #define ID_SHOW_CAPITALSHIPS            1072

fred2/voiceactingmanager.cpp

@@ -118,6 +118,7 @@ BEGIN_MESSAGE_MAP(VoiceActingManager, CDialog)
 	ON_BN_CLICKED(IDC_SHIP_PERSONAS_TO_MESSAGES, OnCopyShipPersonasToMessages)
 	ON_BN_CLICKED(IDC_SET_HEAD_ANIS_USING_MESSAGES_TBL, OnSetHeadANIsUsingMessagesTbl)
 	ON_BN_CLICKED(IDC_CLEAR_PERSONAS_FROM_NON_SENDERS, OnClearPersonasFromNonSenders)
+	ON_BN_CLICKED(IDC_CHECK_ANY_WINGMAN_PERSONAS, OnCheckAnyWingmanPersonas)
 	//}}AFX_MSG_MAP
 END_MESSAGE_MAP()
 
@@ -1142,3 +1143,82 @@ void VoiceActingManager::OnSetHeadANIsUsingMessagesTbl()
 
 	MessageBox("Message head ANIs have been assigned from builtin messages.", "Voice Acting Manager");
 }
+
+void VoiceActingManager::OnCheckAnyWingmanPersonas()
+{
+	char sender_buf[NAME_LENGTH];
+	SCP_string output_msg;
+	bool any_any_wingman = false;
+	int issue_count = 0;
+
+	// go through all messages in the mission
+	for (int i = 0; i < Num_messages - Num_builtin_messages; i++)
+	{
+		auto message = &Messages[i + Num_builtin_messages];
+
+		// find whoever sent this message
+		get_valid_sender(sender_buf, NAME_LENGTH, message);
+
+		// only check <any wingman>
+		if (stricmp(sender_buf, "<any wingman>") != 0)
+			continue;
+		any_any_wingman = true;
+
+		// check the message itself
+		if (message->persona_index < 0)
+		{
+			issue_count++;
+			output_msg += "\n\"";
+			output_msg += message->name;
+			output_msg += "\" - does not have a persona";
+			continue;
+		}
+		if (!(Personas[message->persona_index].flags & PERSONA_FLAG_WINGMAN))
+		{
+			issue_count++;
+			output_msg += "\n\"";
+			output_msg += message->name;
+			output_msg += "\" - does not have a wingman persona";
+			continue;
+		}
+
+		bool found_potential_sender = false;
+
+		// go through all ships in the mission
+		for (auto objp : list_range(&obj_used_list))
+		{
+			if ((objp->type == OBJ_START) || (objp->type == OBJ_SHIP))
+			{
+				if (Ships[objp->instance].persona_index == message->persona_index)
+				{
+					found_potential_sender = true;
+					break;
+				}
+			}
+		}
+
+		if (!found_potential_sender)
+		{
+			issue_count++;
+			output_msg += "\n\"";
+			output_msg += message->name;
+			output_msg += "\" - no ship with persona \"";
+			output_msg += Personas[message->persona_index].name;
+			output_msg += "\" was found";
+		}
+	}
+
+	if (!output_msg.empty())
+	{
+		if (issue_count == 1)
+			output_msg = "The following issue was found for messages sent by <any wingman>:\n" + output_msg;
+		else
+			output_msg = "The following issues were found for messages sent by <any wingman>:\n" + output_msg;
+
+		MessageBox(output_msg.c_str(), "Voice Acting Manager");
+	}
+	else if (!any_any_wingman)
+		MessageBox("All messages have been checked.  There are no messages sent by <any wingman>.", "Voice Acting Manager");
+	else
+		MessageBox("All messages have been checked.  All messages sent by <any wingman> have at least one candidate sender.", "Voice Acting Manager");
+}

fred2/voiceactingmanager.h

@@ -96,6 +96,7 @@ class VoiceActingManager : public CDialog
 	afx_msg void OnCopyShipPersonasToMessages();
 	afx_msg void OnSetHeadANIsUsingMessagesTbl();
 	afx_msg void OnClearPersonasFromNonSenders();
+	afx_msg void OnCheckAnyWingmanPersonas();
 	//}}AFX_MSG
 	DECLARE_MESSAGE_MAP()
 };