Skip to content

Commit ff31bec

Browse files
expound on play-sound-from-file TODO note
1 parent c549cb4 commit ff31bec

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

code/parse/sexp.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14340,7 +14340,12 @@ void sexp_play_sound_from_file(int n)
1434014340
int type = ASF_MENUMUSIC;
1434114341
if (n >= 0)
1434214342
{
14343-
// TODO: SDL3 => make this work with ds_play somehow to get EFX
14343+
// TODO: SDL3 => Having AudioStream::WriteWaveData() pipe the data through
14344+
// new ds functions would be the cleanest way to replicate
14345+
// this but it may not be worth the effort considering EFX
14346+
// is disabled by default and most players probably don't
14347+
// bother enabling it. This really wasn't a well thought out
14348+
// feature in the first place and should maybe be dropped.
1434414349

1434514350
if (eval_sexp(n) != 0)
1434614351
type = ASF_SOUNDFX;

0 commit comments

Comments
 (0)