Skip to content

Commit bfac627

Browse files
committed
Fixed the personally named sequences
1 parent 75aa5e6 commit bfac627

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

packages/adapters/src/kubernetes-sequence-adapter.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { isDefined, readStreamedJSON } from "@scramjet/utility";
1616
import { sequencePackageJSONDecoder } from "./validate-sequence-package-json";
1717
import { adapterConfigDecoder } from "./kubernetes-config-decoder";
1818
import { detectLanguage } from "./utils";
19+
import { IDProvider } from "@scramjet/model";
1920

2021
/**
2122
* Returns existing Sequence configuration.
@@ -32,7 +33,13 @@ async function getRunnerConfigForStoredSequence(sequencesRoot: string, id: strin
3233
sequenceDir = path.join(sequencesRoot, id + "_" + parentId);
3334
} else {
3435
[id, parentId] = id.split("_");
35-
sequenceDir = path.join(sequencesRoot, id + "_" + parentId);
36+
const valid = IDProvider.isValid(id);
37+
38+
if (valid) {
39+
sequenceDir = path.join(sequencesRoot, id + "_" + parentId);
40+
} else {
41+
sequenceDir = path.join(sequencesRoot, id);
42+
}
3643
}
3744
const packageJsonPath = path.join(sequenceDir, "package.json");
3845
const packageJson = await readStreamedJSON(createReadStream(packageJsonPath));

packages/adapters/src/process-sequence-adapter.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import path from "path";
1313
import { exec } from "child_process";
1414
import { isDefined, readStreamedJSON } from "@scramjet/utility";
1515
import { sequencePackageJSONDecoder } from "./validate-sequence-package-json";
16-
import { SequenceAdapterError } from "@scramjet/model";
16+
import { IDProvider, SequenceAdapterError } from "@scramjet/model";
1717
import { detectLanguage } from "./utils";
1818

1919
/**
@@ -31,7 +31,13 @@ async function getRunnerConfigForStoredSequence(sequencesRoot: string, id: strin
3131
sequenceDir = path.join(sequencesRoot, id + "_" + parentId);
3232
} else {
3333
[id, parentId] = id.split("_");
34-
sequenceDir = path.join(sequencesRoot, id + "_" + parentId);
34+
const valid = IDProvider.isValid(id);
35+
36+
if (valid) {
37+
sequenceDir = path.join(sequencesRoot, id + "_" + parentId);
38+
} else {
39+
sequenceDir = path.join(sequencesRoot, id);
40+
}
3541
}
3642
const packageJsonPath = path.join(sequenceDir, "package.json");
3743
const packageJson = await readStreamedJSON(createReadStream(packageJsonPath));
@@ -89,6 +95,7 @@ class ProcessSequenceAdapter implements ISequenceAdapter {
8995
*/
9096
async list(): Promise<SequenceConfig[]> {
9197
const storedSequencesIds = await fs.readdir(this.config.sequencesRoot);
98+
9299
const sequencesConfigs = (await Promise.all(
93100
storedSequencesIds
94101
.map((id) => getRunnerConfigForStoredSequence(this.config.sequencesRoot, id))

0 commit comments

Comments
 (0)