A rule for directly indexing/newindexing globals through getfenv()

[1Kaetar]

a filter_global_assignment rule would serve useful in the case that rename_variables changes variable names to already existing global names. I have currently had an issue with the rename_variables rule overriding local variable names to existing global names and causing errors within my script.

It would also be a fair option to ditch this entirely for an extra parameter to also rename globals.

Examples

--unmodified
a = 0;
local b = 1;

print(a);
-- outputs: 0
-- expected output: 0

--rename_variables transform
a = 0;
local a = 1;

print(a);
-- outputs: 1
-- expected output: 0

--filter_global_assignment > rename_variables transform
getfenv().a = 0;
local a = 1;

print(getfenv().a);
-- outputs: 0
-- expected output: 0

[jeparlefrancais]

Hi!

There is already a parameter to the rename_variables rule that lets you provide arbitrary variable names to skip. If you want to skip "a" you can provide "globals": ["$default", "a"] (there is also $roblox which expands to Roblox globals).

[1Kaetar]

Hi!

There is already a parameter to the rename_variables rule that lets you provide arbitrary variable names to skip. If you want to skip "a" you can provide "globals": ["$default", "a"] (there is also $roblox which expands to Roblox globals).

The script I am transforming has upwards of 2000 local and global variables combined.

[jeparlefrancais]

The script I am transforming has upwards of 2000 local and global variables combined.

It'll still going to avoid any identifiers you write in the config file. If those are runtime-generated then I can see the issue.

But to mitigate the issue, I think the rename_variables rule could be fixed to detect globals in cases like you've shown:

a = 0;
local b = 1;

print(a);

[1Kaetar]

The script I am transforming has upwards of 2000 local and global variables combined.

It'll still going to avoid any identifiers you write in the config file. If those are runtime-generated then I can see the issue.

But to mitigate the issue, I think the rename_variables rule could be fixed to detect globals in cases like you've shown:

a = 0;
local b = 1;

print(a);

Yeah, that is what I meant by "It would also be a fair option to ditch this entirely for an extra parameter to also rename globals."