PEP8 & CI

Author: gpotter2

.github/workflows/cifuzz.yml

@@ -1,7 +1,7 @@
 name: CIFuzz
 
 on:
-  pull_request:
+  push:
     branches: [master]
 
 permissions:

scapy/asn1fields.py

@@ -686,7 +686,7 @@ def i2repr(self, pkt, x):
 
 class ASN1F_omit(ASN1F_field[None, None]):
     """
-    ASN.1 field that is not specified. This is simply ommited on the network.
+    ASN.1 field that is not specified. This is simply omitted on the network.
     This is different from ASN1F_NULL which has a network representation.
     """
     def m2i(self, pkt, s):
@@ -695,7 +695,7 @@ def m2i(self, pkt, s):
 
     def i2m(self, pkt, x):
         # type: (ASN1_Packet, Optional[bytes]) -> bytes
-        return x
+        return b""
 
 
 _CHOICE_T = Union['ASN1_Packet', Type[ASN1F_field[Any, Any]], 'ASN1F_PACKET']

scapy/layers/kerberos.py

@@ -1397,7 +1397,7 @@ def make_checksum(self, text, h="sha256"):
 
     def verify_checksum(self, text):
         """
-        Verifiy paChecksum and paChecksum2
+        Verify paChecksum and paChecksum2
         """
         if self.paChecksum.val != Hash_SHA().digest(text):
             raise ValueError("Bad paChecksum checksum !")
@@ -1438,7 +1438,7 @@ class KRB_AuthPack(ASN1_Packet):
         ASN1F_optional(
             ASN1F_SEQUENCE_OF(
                 "supportedCMSTypes",
-                [],
+                None,
                 X509_AlgorithmIdentifier,
                 explicit_tag=0xA2,
             ),

scapy/layers/msrpce/msnrpc.py

@@ -867,7 +867,7 @@ def establish_secure_channel(
                 not in netr_server_authkerb_response
                 or netr_server_authkerb_response.status != 0
             ):
-                # An error occured
+                # An error occurred
                 netr_server_authkerb_response.show()
                 raise ValueError("NetrServerAuthenticateKerberos failed !")
 

scapy/layers/msrpce/rpcclient.py

@@ -407,7 +407,7 @@ def _get_bind_context(self, interface):
         """
         if interface in self.contexts:
             # We have already found acceptable contexts for this interface,
-            # re-use that.
+            # reuse that.
             return self.contexts[interface]
 
         # NDR 2.0

scapy/layers/tls/cert.py

@@ -1382,7 +1382,7 @@ def tree(self):
         certList = list(self)
 
         # We make a list of certificates we have to search children for, and iterate
-        # through it until it's emtpy.
+        # through it until it's empty.
         todo = list(tree)
 
         # Iterate