You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 30, 2019. It is now read-only.
To me, ignoring regions means that the "global IP" should always be used and the "local IP" should never be used. One sensible way to do this is to use the same region for every node (the empty string, perhaps) and always set the local and global IP addresses to be the same. However, judging by this code, the local IP ends up getting used. That's probably OK, but it does seem a little weird.
So I guess my question is: is this idiom acceptable? I think it might be cleaner to special case a zero value. For example, if the region is empty, then the global IP is always used. Or if the local IP is empty, then then global is always used.
I realize this is a small point, but I was slightly confused by it until I read the full story on what regions were.