feat: change some properties to optionalProperties and adapt inputSchema test accordingly

Author: christopher-exx

csaf_2_1/mandatoryTests/mandatoryTest_6_1_47.js

@@ -13,10 +13,10 @@ const inputSchema = /** @type {const} */ ({
   properties: {
     document: {
       additionalProperties: true,
-      properties: {
+      optionalProperties: {
         tracking: {
           additionalProperties: true,
-          properties: {
+          optionalProperties: {
             id: { type: 'string' },
           },
         },
@@ -44,7 +44,7 @@ const inputSchema = /** @type {const} */ ({
                   optionalProperties: {
                     ssvc_v1: {
                       additionalProperties: true,
-                      properties: {
+                      optionalProperties: {
                         id: { type: 'string' },
                       },
                     },
@@ -81,7 +81,7 @@ export function mandatoryTest_6_1_47(doc) {
     vulnerability.metrics?.forEach((metric, metricIndex) => {
       if (metric.content?.ssvc_v1) {
         const ssvcId = metric.content.ssvc_v1.id
-        if (ssvcId === doc.document.tracking.id) {
+        if (ssvcId === doc.document.tracking?.id) {
           if (doc.vulnerabilities.length > 1) {
             ctx.isValid = false
             ctx.errors.push({

tests/csaf_2_1/mandatoryTest_6_1_47.js

@@ -2,16 +2,17 @@ import assert from 'node:assert/strict'
 import { mandatoryTest_6_1_47 } from '../../csaf_2_1/mandatoryTests/mandatoryTest_6_1_47.js'
 import { expect } from 'chai'
 
-const validInputSchemaTestWithEmptyVulnerability6_1_47 = {
+const failingInputSchemaTestWithEmptyVulnerability6_1_47 = {
+  document: {},
   vulnerabilities: [
-    {}, // even this vulnerability is empty, the test should not fail due to the inputSchema
+    {}, // even this vulnerability is empty, the test should run
     {
       cve: 'CVE-1900-0001',
       metrics: [
         {
           content: {
             ssvc_v1: {
-              id: 'CVE-1900-0001',
+              id: 'CVE-1900-0002',
               schemaVersion: '1-0-1',
               selections: [
                 {
@@ -37,8 +38,8 @@ describe('mandatoryTest_6_1_47', function () {
   })
   it('test input schema with empty json object in vulnerabilities', async function () {
     const result = mandatoryTest_6_1_47(
-      validInputSchemaTestWithEmptyVulnerability6_1_47
+      failingInputSchemaTestWithEmptyVulnerability6_1_47
     )
-    expect(result.errors.length).to.eq(0)
+    expect(result.errors.length).to.eq(1)
   })
 })