change problem edit URI

api/problem -> api/problem/<int:id>

Author: szdytom

problem/tests.py

@@ -3,7 +3,7 @@
 from rest_framework import status
 from rest_framework.test import APIRequestFactory, force_authenticate
 
-
+from .models import Problem
 from .views import ProblemView, TagView
 from account.models import User
 
@@ -61,6 +61,31 @@ def testX_post_new_problem(self):
         response = self.view(request)
         self.assertEqual(response.status_code, status.HTTP_201_CREATED)
 
+    def testW_change_problem(self):
+        request_data = {
+            "title": "Not Hard Problem",
+            "description": "This is description",
+            "pid": 8,
+            "allow_html": True,
+            "tags": [4, 3, 1]
+        }
+
+        ac_data = {
+            "enabled": True
+        }
+
+        request = self.factory.patch(self.base_url, data=request_data)
+        force_authenticate(request, User.objects.get(username="admin"))
+        response = self.view(request, pid=5)
+        self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
+
+        target = Problem.objects.get(pid=8)
+        self.assertEqual(target.pid, request_data["pid"])
+        self.assertEqual(target.description, request_data["description"])
+        self.assertEqual(target.title, request_data["title"])
+        self.assertEqual(target.allow_html, request_data["allow_html"])
+        self.assertEqual(target.enabled, ac_data["enabled"])
+
 
 class TagViewTest(TestCase):
     fixtures = ["testdatabase.yaml"]

problem/views.py

@@ -40,27 +40,22 @@ def post(self, request):
         ps.save()
         return Response(status=status.HTTP_201_CREATED)
 
-    @method_decorator(syllable_required("pid", int))
-    @method_decorator(
-        permission_required("problem.change_problem", raise_exception=True)
-    )
-    def patch(slef, request):
+    @method_decorator(parameter_required("pid"))
+    @method_decorator(permission_required("problem.change_problem", raise_exception=True))
+    def patch(self, request, pid):
         data = request.data
-        id = data.get("pid")
 
-        problem = get_object_or_404(Problem, pid=id)
+        problem = get_object_or_404(Problem, pid=pid)
         ps = ProblemSerializer(problem, data=data, partial=True)
         ps.is_valid(raise_exception=True)
         ps.save()
         return Response(status=status.HTTP_204_NO_CONTENT)
 
-    @method_decorator(syllable_required("pid", int))
     @method_decorator(permission_required("problem.delete_problem"))
-    def delete(self, request):
+    def delete(self, request, pid):
         data = request.data
-        id = data.get("pid")
 
-        problem = get_object_or_404(Problem, pid=id)
+        problem = get_object_or_404(Problem, pid=pid)
         problem.delete()
         return Response(status=status.HTTP_204_NO_CONTENT)