Skip to content

anyTargetChanged prevent gutter updates when binary is unchanged but editor source has changed #212

@fredsa

Description

@fredsa

Reproducing this is a bit convoluted in the current CodeMirror5 implementation, but this 'bug' is there.

Recipe:

  1. Modify the source code such that the compiled binary output does not change
    1. Pick any line of valid machine code
    2. Add an error (i.e. change LDA to XLDA)
    3. Move this line down a few lines — gutter does not update while in the error state
    4. Remove the error (i.e. remove the X)
  2. View gutter information and watch it go stale

EXPECTED:

  • Now that the code compiles again, the gutter data should match source code

ACTUAL:

  • Gutter info remains as it was prior to the edits, data is shown in the wrong line
  • anyTargetChanged does its job and returns false, gutter updates are skipped

POSSIBLE FIX:

  • Always update the gutter data after the compilation step

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions