Merge pull request #1349 from seleniumbase/fix-ie-issue

Fix IE issue that prevented the browser from quitting after tests

Author: mdmintz

README.md

@@ -5,10 +5,10 @@
 <meta property="og:image" content="https://seleniumbase.io/cdn/img/mac_sb_logo_5.png" />
 <link rel="icon" href="https://seleniumbase.io/img/green_logo2.png" />
 
-<h2 align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/mac_sb_banner_t.png" alt="SeleniumBase" title="SeleniumBase" width="760" /></a></h2>
+<h2 align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/mac_sb_banner_t.png" alt="SeleniumBase" title="SeleniumBase" width="672" /></a></h2>
 
 <p align="center">
-<b>Everything you need to test web apps.</b>
+<b>The most advanced open-source automation framework on the Planet.</b>
 </p>
 
 <!-- View on GitHub -->
@@ -53,7 +53,7 @@
 
 <p align="left">
 ✅ Smart-waiting code prevents flaky tests.<br />
-✅ Supports Chromium, Firefox, and Safari.<br />
+✅ Runs on Chromium, Firefox, IE, & Safari.<br />
 ✅ Supports Linux, macOS, and Windows.<br />
 </p>
 

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "3.2.4"
+__version__ = "3.2.5"

seleniumbase/behave/behave_sb.py

@@ -920,7 +920,11 @@ def _perform_behave_unconfigure_():
         # Close the shared browser session
         if sb_config.shared_driver:
             try:
-                if not is_windows or sb_config.shared_driver.service.process:
+                if (
+                    not is_windows
+                    or sb_config.browser == "ie"
+                    or sb_config.shared_driver.service.process
+                ):
                     sb_config.shared_driver.quit()
             except AttributeError:
                 pass
@@ -983,7 +987,11 @@ def _perform_behave_unconfigure_():
 def do_final_driver_cleanup_as_needed():
     try:
         if hasattr(sb_config, "last_driver") and sb_config.last_driver:
-            if not is_windows or sb_config.last_driver.service.process:
+            if (
+                not is_windows
+                or sb_config.browser == "ie"
+                or sb_config.last_driver.service.process
+            ):
                 sb_config.last_driver.quit()
     except Exception:
         pass

seleniumbase/fixtures/base_case.py

@@ -10465,7 +10465,11 @@ def quit_extra_driver(self, driver=None):
                 "Use this method only if get_new_driver() has been called."
             )
         try:
-            if not is_windows or driver.service.process:
+            if (
+                not is_windows
+                or self.browser == "ie"
+                or driver.service.process
+            ):
                 driver.quit()
         except AttributeError:
             pass
@@ -12419,7 +12423,11 @@ def __quit_all_drivers(self):
         self._drivers_list.reverse()  # Last In, First Out
         for driver in self._drivers_list:
             try:
-                if not is_windows or driver.service.process:
+                if (
+                    not is_windows
+                    or self.browser == "ie"
+                    or driver.service.process
+                ):
                     if not delay_driver_quit:
                         driver.quit()
                     else:

seleniumbase/plugins/pytest_plugin.py

@@ -1463,7 +1463,11 @@ def _perform_pytest_unconfigure_():
         # Close the shared browser session
         if sb_config.shared_driver:
             try:
-                if not is_windows or sb_config.shared_driver.service.process:
+                if (
+                    not is_windows
+                    or sb_config.browser == "ie"
+                    or sb_config.shared_driver.service.process
+                ):
                     sb_config.shared_driver.quit()
             except AttributeError:
                 pass

seleniumbase/plugins/selenium_plugin.py

@@ -779,7 +779,11 @@ def finalize(self, result):
     def afterTest(self, test):
         try:
             # If the browser window is still open, close it now.
-            if not is_windows or self.driver.service.process:
+            if (
+                not is_windows
+                or test.test.browser == "ie"
+                or self.driver.service.process
+            ):
                 self.driver.quit()
         except AttributeError:
             pass