Refactor default browser resolutions into a settings file

Author: mdmintz

examples/custom_settings.py

@@ -30,6 +30,14 @@
 # If True and --proxy=IP_ADDRESS:PORT is invalid, then error immediately.
 RAISE_INVALID_PROXY_STRING_EXCEPTION = True
 
+# Default browser resolutions when opening new windows for tests.
+# (Headless resolutions take priority, and include all browsers.)
+# (Firefox starts maximized by default when running in GUI Mode.)
+CHROME_START_WIDTH = 1250
+CHROME_START_HEIGHT = 840
+HEADLESS_START_WIDTH = 1440
+HEADLESS_START_HEIGHT = 1880
+
 # Changing the default behavior of MasterQA Mode.
 MASTERQA_DEFAULT_VALIDATION_MESSAGE = "Does the page look good?"
 MASTERQA_WAIT_TIME_BEFORE_VERIFY = 0.5

seleniumbase/config/settings.py

@@ -85,6 +85,14 @@
 # (This applies when using --proxy=[PROXY_STRING] for using a proxy server.)
 RAISE_INVALID_PROXY_STRING_EXCEPTION = True
 
+# Default browser resolutions when opening new windows for tests.
+# (Headless resolutions take priority, and include all browsers.)
+# (Firefox starts maximized by default when running in GUI Mode.)
+CHROME_START_WIDTH = 1250
+CHROME_START_HEIGHT = 840
+HEADLESS_START_WIDTH = 1440
+HEADLESS_START_HEIGHT = 1880
+
 # #####>>>>>----- MasterQA SETTINGS -----<<<<<#####
 # ##### (Used when importing MasterQA as the parent class)
 

seleniumbase/fixtures/base_case.py

@@ -1457,8 +1457,10 @@ def get_new_driver(self, browser=None, headless=None,
             self.driver = new_driver
             if self.headless:
                 # Make sure the invisible browser window is big enough
+                width = settings.HEADLESS_START_WIDTH
+                height = settings.HEADLESS_START_HEIGHT
                 try:
-                    self.set_window_size(1440, 1880)
+                    self.set_window_size(width, height)
                     self.wait_for_ready_state_complete()
                 except Exception:
                     # This shouldn't fail, but in case it does,
@@ -1467,8 +1469,8 @@ def get_new_driver(self, browser=None, headless=None,
                     pass
             else:
                 if self.browser == 'chrome':
-                    width = 1250
-                    height = 840
+                    width = settings.CHROME_START_WIDTH
+                    height = settings.CHROME_START_HEIGHT
                     try:
                         if self.maximize_option:
                             self.driver.maximize_window()
@@ -4198,10 +4200,12 @@ def setUp(self, masterqa_mode=False):
                 self.testcase_manager.insert_testcase_data(data_payload)
                 self.case_start_time = int(time.time() * 1000)
             if self.headless:
+                width = settings.HEADLESS_START_WIDTH
+                height = settings.HEADLESS_START_HEIGHT
                 try:
                     # from pyvirtualdisplay import Display  # Skip for own lib
                     from seleniumbase.virtual_display.display import Display
-                    self.display = Display(visible=0, size=(1440, 1880))
+                    self.display = Display(visible=0, size=(width, height))
                     self.display.start()
                     self.headless_active = True
                 except Exception: