Make improvements to multithreaded downloads

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -6427,11 +6427,15 @@ def save_element_as_image_file(
     def download_file(self, file_url, destination_folder=None):
         """Downloads the file from the url to the destination folder.
         If no destination folder is specified, the default one is used.
-        (The default [Downloads Folder] = "./downloaded_files")"""
-        if not destination_folder:
-            destination_folder = constants.Files.DOWNLOADS_FOLDER
-        if not os.path.exists(destination_folder):
-            os.makedirs(destination_folder)
+        (The default folder for downloads is "./downloaded_files")"""
+        download_file_lock = fasteners.InterProcessLock(
+            constants.MultiBrowser.DOWNLOAD_FILE_LOCK
+        )
+        with download_file_lock:
+            if not destination_folder:
+                destination_folder = constants.Files.DOWNLOADS_FOLDER
+            if not os.path.exists(destination_folder):
+                os.makedirs(destination_folder)
         page_utils._download_file_to(file_url, destination_folder)
         if self.recorder_mode:
             url = self.get_current_url()

seleniumbase/fixtures/constants.py

@@ -124,6 +124,7 @@ class MultiBrowser:
     DRIVER_FIXING_LOCK = Files.DOWNLOADS_FOLDER + "/driver_fixing.lock"
     DRIVER_REPAIRED = Files.DOWNLOADS_FOLDER + "/driver_fixed.lock"
     CERT_FIXING_LOCK = Files.DOWNLOADS_FOLDER + "/cert_fixing.lock"
+    DOWNLOAD_FILE_LOCK = Files.DOWNLOADS_FOLDER + "/download_file.lock"
 
 
 class SavedCookies:

seleniumbase/fixtures/page_utils.py

@@ -1,10 +1,10 @@
-"""
-This module contains useful utility methods.
-"""
+"""This module contains useful utility methods."""
 import codecs
+import fasteners
 import os
 import re
 import requests
+from seleniumbase.fixtures import constants
 
 
 def get_domain_url(url):
@@ -261,8 +261,12 @@ def _download_file_to(file_url, destination_folder, new_file_name=None):
         file_name = file_url.split("/")[-1]
     r = requests.get(file_url)
     file_path = os.path.join(destination_folder, file_name)
-    with open(file_path, "wb") as code:
-        code.write(r.content)
+    download_file_lock = fasteners.InterProcessLock(
+        constants.MultiBrowser.DOWNLOAD_FILE_LOCK
+    )
+    with download_file_lock:
+        with open(file_path, "wb") as code:
+            code.write(r.content)
 
 
 def _save_data_as(data, destination_folder, file_name):