Merge pull request #1699 from seleniumbase/upgrade-selenium

Upgrade selenium to 4.8.0

Author: mdmintz

mkdocs_build/requirements.txt

@@ -18,7 +18,7 @@ readme-renderer==37.3
 pymdown-extensions==9.9.2
 importlib-metadata==6.0.0
 pipdeptree==2.3.3
-bleach==5.0.1
+bleach==6.0.0
 lunr==0.6.2
 nltk==3.8.1
 tornado==6.2

requirements.txt

@@ -40,7 +40,7 @@ websockets==10.4;python_version>="3.7"
 pyopenssl==23.0.0;python_version>="3.7"
 wsproto==1.2.0;python_version>="3.7"
 selenium==3.141.0;python_version<"3.7"
-selenium==4.7.2;python_version>="3.7"
+selenium==4.8.0;python_version>="3.7"
 msedge-selenium-tools==3.141.3;python_version<"3.7"
 more-itertools==8.14.0;python_version<"3.7"
 more-itertools==9.0.0;python_version>="3.7"

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "4.11.9"
+__version__ = "4.12.0"

seleniumbase/undetected/__init__.py

@@ -101,8 +101,8 @@ def __init__(
         log_level: (default: adapts to python global log level)
 
         headless: (default: False)
-            Use headless mode. (Can also be specified with ChromeOptions.)
-            Warning: this lowers undetectability and is not fully supported.
+            Use headless mode.
+            (Already handled by seleniumbase/core/browser_launcher.py)
 
         patch_driver: (default: True)
             Patches uc_driver to be undetectable if not already patched.
@@ -227,11 +227,6 @@ def __init__(
                     "--password-store=basic",
                 ]
             )
-        if headless or options.headless:
-            options.headless = True
-            options.add_argument("--no-sandbox")
-            # Fixes "could not connect to chrome" error when running
-            # on Linux when using a privileged user such as root.
         options.add_argument(
             "--log-level=%d" % log_level
             or divmod(logging.getLogger().getEffectiveLevel(), 10)[0]
@@ -304,8 +299,6 @@ def __init__(
             reactor = Reactor(self)
             reactor.start()
             self.reactor = reactor
-        if options.headless:
-            self._configure_headless()
         self._web_element_cls = WebElement
 
     def __getattribute__(self, item):
@@ -325,56 +318,6 @@ def newfunc(*args, **kwargs):
                 return newfunc
             return original
 
-    def _configure_headless(self):
-        orig_get = self.get
-        logger.info("setting properties for headless")
-
-        def get_wrapped(*args, **kwargs):
-            if self.execute_script("return navigator.webdriver"):
-                logger.info("patch navigator.webdriver")
-                self.execute_cdp_cmd(
-                    "Page.addScriptToEvaluateOnNewDocument",
-                    {
-                        "source": """
-                        Object.defineProperty(window, 'navigator', {
-                        value: new Proxy(navigator, {
-                            has: (target, key) => (
-                                key === 'webdriver' ? false : key in target
-                            ),
-                            get: (target, key) =>
-                                key === 'webdriver' ?
-                                false :
-                                typeof target[key] === 'function' ?
-                                target[key].bind(target) :
-                                target[key]
-                        })
-                        });
-                    """
-                    },
-                )
-                logger.info("Patch user-agent string")
-                self.execute_cdp_cmd(
-                    "Network.setUserAgentOverride",
-                    {
-                        "userAgent": self.execute_script(
-                            "return navigator.userAgent"
-                        ).replace("Headless", "")
-                    },
-                )
-                self.execute_cdp_cmd(
-                    "Page.addScriptToEvaluateOnNewDocument",
-                    {
-                        "source": """
-                            Object.defineProperty(
-                                navigator, 'maxTouchPoints', {
-                                    get: () => 1
-                            })"""
-                    },
-                )
-            return orig_get(*args, **kwargs)
-
-        self.get = get_wrapped
-
     def __dir__(self):
         return object.__dir__(self)
 

setup.py

@@ -164,7 +164,7 @@
         'pyopenssl==23.0.0;python_version>="3.7"',
         'wsproto==1.2.0;python_version>="3.7"',
         'selenium==3.141.0;python_version<"3.7"',
-        'selenium==4.7.2;python_version>="3.7"',
+        'selenium==4.8.0;python_version>="3.7"',
         'msedge-selenium-tools==3.141.3;python_version<"3.7"',
         'more-itertools==8.14.0;python_version<"3.7"',
         'more-itertools==9.0.0;python_version>="3.7"',