Merge pull request #1533 from seleniumbase/fix-issue-with-behave-headless-mode

Fix issue with "behave" headless mode, and more

Author: mdmintz

README.md

@@ -5,9 +5,9 @@
 <meta property="og:image" content="https://seleniumbase.github.io/cdn/img/mac_sb_logo_5b.png" />
 <link rel="icon" href="https://seleniumbase.github.io/img/green_logo2.png" />
 
-<p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.github.io/cdn/img/mac_sb_logo_bw.png" alt="SeleniumBase" title="SeleniumBase" width="408" /></a></p>
+<p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.github.io/cdn/img/mac_sb_logo_bg6.png" alt="SeleniumBase" title="SeleniumBase" width="408" /></a></p>
 
-<p align="center"><b>A framework for browser automation & testing with <a href="https://www.python.org/about/" target="_blank">Python</a>.</b><br />SeleniumBase extends <a href="https://www.selenium.dev/documentation/webdriver/" target="_blank">Selenium WebDriver</a> as a <a href="https://docs.pytest.org/en/latest/how-to/usage.html" target="_blank">pytest</a> plugin.</p>
+<p align="center"><b>A web automation framework for E2E testing with <a href="https://www.python.org/about/" target="_blank">Python</a>.</b><br />SeleniumBase extends <a href="https://www.selenium.dev/documentation/webdriver/" target="_blank">Selenium WebDriver</a> as a <a href="https://docs.pytest.org/en/latest/how-to/usage.html" target="_blank">pytest</a> plugin.</p>
 
 <p align="center"><a href="https://pypi.python.org/pypi/seleniumbase" target="_blank"><img src="https://img.shields.io/pypi/v/seleniumbase.svg?color=3399EE" alt="PyPI version" /></a> <a href="https://github.com/seleniumbase/SeleniumBase/releases" target="_blank"><img src="https://img.shields.io/github/v/release/seleniumbase/SeleniumBase.svg?color=22AAEE" alt="GitHub version" /></a> <a href="https://seleniumbase.io"><img src="https://img.shields.io/badge/docs-seleniumbase.io-11BBAA.svg" alt="SeleniumBase Docs" /></a> <a href="https://github.com/seleniumbase/SeleniumBase/actions" target="_blank"><img src="https://github.com/seleniumbase/SeleniumBase/workflows/CI%20build/badge.svg" alt="SeleniumBase GitHub Actions" /></a> <a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://badges.gitter.im/seleniumbase/SeleniumBase.svg" alt="SeleniumBase" /></a></p>
 

requirements.txt

@@ -5,7 +5,7 @@ packaging>=20.9;python_version<"3.6"
 packaging>=21.3;python_version>="3.6"
 setuptools>=44.1.1;python_version<"3.6"
 setuptools>=59.6.0;python_version>="3.6" and python_version<"3.7"
-setuptools>=65.4.0;python_version>="3.7"
+setuptools>=65.4.1;python_version>="3.7"
 tomli>=1.2.3;python_version>="3.6" and python_version<"3.7"
 tomli>=2.0.1;python_version>="3.7"
 tqdm>=4.64.1
@@ -125,7 +125,7 @@ rich==12.5.1;python_version>="3.6" and python_version<"4.0"
 
 coverage==5.5;python_version<"3.6"
 coverage==6.2;python_version>="3.6" and python_version<"3.7"
-coverage==6.4.4;python_version>="3.7"
+coverage==6.5.0;python_version>="3.7"
 pytest-cov==2.12.1;python_version<"3.6"
 pytest-cov==4.0.0;python_version>="3.6"
 flake8==3.7.9;python_version<"3.6"

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "4.5.0"
+__version__ = "4.5.1"

seleniumbase/fixtures/base_case.py

@@ -99,11 +99,11 @@ def __initialize_variables(self):
         self.driver = None
         self.environment = None
         self.env = None  # Add a shortened version of self.environment
-        self.headless = None
-        self.headless2 = None  # The new headless mode for Chromium
-        self.version_tuple = (
-            tuple([int(i) for i in __version__.split(".") if i.isdigit()])
-        )
+        self.version_list = [
+            int(i) for i in __version__.split(".") if i.isdigit()
+        ]
+        self.version_tuple = tuple(self.version_list)
+        self.version_info = self.version_tuple
         self.__page_sources = []
         self.__extra_actions = []
         self.__js_start_time = 0
@@ -5588,12 +5588,14 @@ def get_unique_links(self):
         "a"->"href", "img"->"src", "link"->"href", and "script"->"src".
         """
         self.__check_scope()
+        if settings.SKIP_JS_WAITS and self.page_load_strategy == "none":
+            time.sleep(0.16)
         try:
             self.wait_for_element_visible("body", timeout=1.5)
         except Exception:
             pass
-        page_url = self.get_current_url()
         soup = self.get_beautiful_soup(self.get_page_source())
+        page_url = self.get_current_url()
         links = page_utils._get_unique_links(page_url, soup)
         return links
 

setup.py

@@ -131,7 +131,7 @@
         'packaging>=21.3;python_version>="3.6"',
         'setuptools>=44.1.1;python_version<"3.6"',
         'setuptools>=59.6.0;python_version>="3.6" and python_version<"3.7"',
-        'setuptools>=65.4.0;python_version>="3.7"',
+        'setuptools>=65.4.1;python_version>="3.7"',
         'tomli>=1.2.3;python_version>="3.6" and python_version<"3.7"',
         'tomli>=2.0.1;python_version>="3.7"',
         "tqdm>=4.64.1",
@@ -251,7 +251,7 @@
         "coverage": [
             'coverage==5.5;python_version<"3.6"',
             'coverage==6.2;python_version>="3.6" and python_version<"3.7"',
-            'coverage==6.4.4;python_version>="3.7"',
+            'coverage==6.5.0;python_version>="3.7"',
             'pytest-cov==2.12.1;python_version<"3.6"',
             'pytest-cov==4.0.0;python_version>="3.6"',
         ],