Merge pull request #1414 from seleniumbase/handle-edge-cases

Handle edge cases with EdgeDriver and js_click()

Author: mdmintz

README.md

@@ -2,10 +2,10 @@
 <meta property="og:title" content="SeleniumBase: Python Web Automation and E2E Testing" />
 <meta property="og:description" content="Fast, easy, and reliable Web/UI testing with Python." />
 <meta property="og:keywords" content="Python, pytest, selenium, webdriver, testing, automation, seleniumbase, framework, RPA, behave, BDD, nosetests, dashboard, recorder, reports, gui, screenshots">
-<meta property="og:image" content="https://seleniumbase.io/cdn/img/mac_sb_logo_5.png" />
+<meta property="og:image" content="https://seleniumbase.io/cdn/img/mac_sb_logo_5b.png" />
 <link rel="icon" href="https://seleniumbase.io/img/green_logo2.png" />
 
-<p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/mac_sb_logo_5b.png" alt="SeleniumBase" title="SeleniumBase" width="320" /></a></p>
+<p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/mac_sb_logo_3c.png" alt="SeleniumBase" title="SeleniumBase" width="320" /></a></p>
 <p align="center"><b>Powerful end-to-end testing with <a href="https://www.selenium.dev/documentation/">Selenium</a>, <a href="https://www.python.org/about/">Python</a>, and <a href="https://docs.pytest.org/en/latest/how-to/usage.html">pytest</a>.</b></p>
 
 <p align="center"><a href="https://pypi.python.org/pypi/seleniumbase" target="_blank"><img src="https://img.shields.io/pypi/v/seleniumbase.svg?color=3399EE" alt="PyPI version" /></a> <a href="https://github.com/seleniumbase/SeleniumBase/releases" target="_blank"><img src="https://img.shields.io/github/v/release/seleniumbase/SeleniumBase.svg?color=22AAEE" alt="GitHub version" /></a> <a href="https://seleniumbase.io"><img src="https://img.shields.io/badge/docs-seleniumbase.io-11BBAA.svg" alt="SeleniumBase Docs" /></a> <a href="https://github.com/seleniumbase/SeleniumBase/actions" target="_blank"><img src="https://github.com/seleniumbase/SeleniumBase/workflows/CI%20build/badge.svg" alt="SeleniumBase GitHub Actions" /></a> <a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://badges.gitter.im/seleniumbase/SeleniumBase.svg" alt="SeleniumBase" /></a></p>

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "3.5.3"
+__version__ = "3.5.4"

seleniumbase/core/browser_launcher.py

@@ -1837,6 +1837,14 @@ def get_local_driver(
                         edge_version = e.msg.split(
                             "only supports MSEdge version "
                         )[1].split(" ")[0]
+                elif "DevToolsActivePort file doesn't exist" in e.msg:
+                    service = EdgeService(
+                        executable_path=LOCAL_EDGEDRIVER,
+                        log_path=os.path.devnull,
+                    )
+                    # https://stackoverflow.com/a/56638103/7058266
+                    edge_options.add_argument("--remote-debugging-port=9222")
+                    return Edge(service=service, options=edge_options)
                 if not auto_upgrade_edgedriver:
                     raise Exception(e.msg)  # Not an obvious fix. Raise.
                 else:
@@ -1884,6 +1892,14 @@ def get_local_driver(
                         edge_version = e.msg.split(
                             "only supports MSEdge version "
                         )[1].split(" ")[0]
+                elif "DevToolsActivePort file doesn't exist" in e.msg:
+                    service = EdgeService(
+                        executable_path=LOCAL_EDGEDRIVER,
+                        log_path=os.path.devnull,
+                    )
+                    # https://stackoverflow.com/a/56638103/7058266
+                    edge_options.add_argument("--remote-debugging-port=9222")
+                    return Edge(service=service, options=edge_options)
                 if not auto_upgrade_edgedriver:
                     raise Exception(e.msg)  # Not an obvious fix. Raise.
                 else:

seleniumbase/fixtures/base_case.py

@@ -11599,9 +11599,22 @@ def __js_click(self, selector, by="css selector"):
         )
         try:
             self.execute_script(script)
-        except Exception:
-            # If the regular mouse-simulated click fails, do a basic JS click
+        except Exception as e:
             self.wait_for_ready_state_complete()
+            if "Cannot read properties of null" in e.msg:
+                page_actions.wait_for_element_present(
+                    self.driver, selector, by, timeout=3
+                )
+                if not page_actions.is_element_clickable(
+                    self.driver, selector, by
+                ):
+                    try:
+                        self.wait_for_element_clickable(
+                            selector, by, timeout=1.2
+                        )
+                    except Exception:
+                        pass
+            # If the regular mouse-simulated click fails, do a basic JS click
             script = (
                 """document.querySelector('%s').click();"""
                 % css_selector