-
Notifications
You must be signed in to change notification settings - Fork 2
Add dedicated ace-spec shader for ACE_SPEC_RARE cards #10
Description
Description
ACE_SPEC_RARE cards currently fall through to the ultra-rare shader (cardCatalog.ts:58), but they have a distinct holographic treatment in the physical TCG that deserves its own shader. A new ace-spec.frag fragment shader should be created to give these cards their own visual identity.
Use Case / Motivation
Ace Spec cards (e.g. PAF #141) have a unique foil pattern that differs from standard Ultra Rares. Using the generic ultra-rare shader for them loses that distinction. A dedicated shader would improve visual accuracy and make the collection feel more authentic.
Proposed Solution
- New shader: Create
src/shaders/ace-spec.fragwith a visual treatment tailored to Ace Spec cards - Update
mapHoloType()insrc/data/cardCatalog.ts— change theACE_SPEC_RAREcase (line 58) from'ultra-rare'to'ace-spec' - Register the new
HoloTypeinsrc/types/(add'ace-spec'to theHoloTypeunion) - Add uniform↔config mappings to
src/data/shaderRegistry.ts(SHADER_UNIFORM_REGISTRY) - Add default values to
src/data/defaults.ts - Import the shader in
src/three/buildCard.tsand add the case for material creation - Update tests: adjust the existing test in
cardCatalog.test.ts(line 28-29) to expect'ace-spec'instead of'ultra-rare', and add the new shader toshader-validation.test.ts/shader-compilation.test.ts - Update docs:
CLAUDE.mdshader selection table anddocs/CARD-SETS.md
Reference card
Use PAF #141 (sv4-5_en set) as the primary reference for developing and testing the shader.
Alternatives Considered
Keep using ultra-rare for Ace Spec cards. This works but misses the opportunity to reproduce the distinct Ace Spec foil pattern.