You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.
2
+
We appreciate the effort for this pull request, but before that, please make sure you read the [contribution guidelines](https://github.com/sendgrid/sendgrid-python/blob/v4/CONTRIBUTING.md), and then fill out the blanks below.
3
3
4
4
5
5
Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged!
6
6
e.g.
7
7
Fixes #1
8
8
Closes #2
9
9
-->
10
-
# Fixes #
10
+
# Fixes #X
11
11
12
12
### Checklist
13
13
- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
@@ -19,6 +19,5 @@ Closes #2
19
19
20
20
### Short description of what this PR does:
21
21
-
22
-
-
23
22
24
-
If you have questions, please send an email to [SendGrid](mailto:dx@sendgrid.com), or file a GitHub Issue in this repository.
23
+
If you have questions, please send an email to [Twilio SendGrid](mailto:dx@sendgrid.com), or file a GitHub Issue in this repository.
Copy file name to clipboardExpand all lines: CHANGELOG.md
+10-17Lines changed: 10 additions & 17 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,23 +1,16 @@
1
1
# Change Log
2
2
All notable changes to this project will be documented in this file.
3
3
4
-
## [5.6.0] - 2018-08-20 ##
5
-
### Added
6
-
-[PR #593](https://github.com/sendgrid/sendgrid-python/pull/593): Adds support for dynamic template data. Big thanks to [Slam](https://github.com/3lnc) for the PR! Also, big thanks to [Wojciech Bartosiak](https://github.com/wojtek-fliposports) for [PR #597](https://github.com/sendgrid/sendgrid-python/pull/597)!
7
-
8
-
## [5.5.0] - 2018-08-16 ##
9
-
### Added
10
-
-[PR #588](https://github.com/sendgrid/sendgrid-python/pull/588): Updates the Readme to include environment variable setup in windows. Big thanks to [Bhargav Chandaka](https://github.com/bchandaka) for the PR!
11
-
-[PR #599](https://github.com/sendgrid/sendgrid-python/pull/599): Updates the Readme to include additional API Key instruction. Big thanks to [Anshul Singhal](https://github.com/af4ro) for the PR!
12
-
-[PR #600](https://github.com/sendgrid/sendgrid-python/pull/600): Add CodeTriage Badge. Big thanks to [Anshul Singhal](https://github.com/af4ro) for the PR!
13
-
-[PR #601](https://github.com/sendgrid/sendgrid-python/pull/601): Readability improvements to CONTRIBUTING.md. Big thanks to [Anshul Singhal](https://github.com/af4ro) for the PR!
14
-
-[PR #604](https://github.com/sendgrid/sendgrid-python/pull/604): Readability improvements to CONTRIBUTING.md. Big thanks to [agnesjang98](https://github.com/agnesjang98) for the PR!
15
-
16
-
### Fixed
17
-
-[PR #595](https://github.com/sendgrid/sendgrid-python/pull/595): Change type of category in Mail.add_category from string to Category. Big thanks to [Phawin Khongkhasawan](https://github.com/lifez) for the PR!
18
-
-[PR #596](https://github.com/sendgrid/sendgrid-python/pull/596): Fix Docker build. Big thanks to [Phawin Khongkhasawan](https://github.com/lifez) for the PR!
19
-
-[PR #598](https://github.com/sendgrid/sendgrid-python/pull/598): Fix python3 print example in TROUBLESHOOTING.md. Big thanks to [Ryan Jarvis](https://github.com/Cabalist) for the PR!
20
-
-[PR #603](https://github.com/sendgrid/sendgrid-python/pull/603): Update TROUBLESHOOTING.md to link to correct use cases page. Big thanks to [James Purpura](https://github.com/jpurpura) for the PR!
Copy file name to clipboardExpand all lines: CODE_OF_CONDUCT.md
+7-8Lines changed: 7 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,7 @@
1
1
# SendGrid Community Code of Conduct
2
-
2
+
3
3
The SendGrid open source community is made up of members from around the globe with a diverse set of skills, personalities, and experiences. It is through these differences that our community experiences successes and continued growth. When you're working with members of the community, we encourage you to follow these guidelines, which help steer our interactions and strive to maintain a positive, successful and growing community.
4
-
4
+
5
5
### Be Open
6
6
Members of the community are open to collaboration, whether it's on pull requests, code reviews, approvals, issues or otherwise. We're receptive to constructive comments and criticism, as the experiences and skill sets of all members contribute to the whole of our efforts. We're accepting of all who wish to take part in our activities, fostering an environment where anyone can participate, and everyone can make a difference.
7
7
@@ -18,7 +18,7 @@
18
18
19
19
### Interpretation
20
20
This Code is not exhaustive or complete. It is not a rulebook; it serves to distill our common understanding of a collaborative, shared environment and goals. We expect it to be followed in spirit as much as in the letter. When in doubt, try to abide by [SendGrid’s cultural values](https://sendgrid.com/blog/employee-engagement-the-4h-way) defined by our “4H’s”: Happy, Hungry, Humble and Honest.
21
-
21
+
22
22
### Enforcement
23
23
Most members of the SendGrid community always comply with this Code, not because of the existence of this Code, but because they have long experience participating in open source communities where the conduct described above is normal and expected. However, failure to observe this Code may be grounds for suspension, reporting the user for abuse or changing permissions for outside contributors.
24
24
@@ -31,12 +31,11 @@
31
31
32
32
## Submission to SendGrid Repositories
33
33
Finally, just a reminder, changes to the SendGrid repositories will only be accepted upon completion of the [SendGrid Contributor Agreement](https://cla.sendgrid.com).
34
-
34
+
35
35
## Attribution
36
36
37
37
SendGrid thanks the following, on which it draws for content and inspiration:
38
38
39
-
[Python Community Code of Conduct](https://www.python.org/psf/codeofconduct/)<br>
40
-
[Open Source Initiative General Code of Conduct](https://opensource.org/codeofconduct) <br>
41
-
[Apache Code of Conduct](https://www.apache.org/foundation/policies/conduct.html) <br>
42
-
39
+
*[Python Community Code of Conduct](https://www.python.org/psf/codeofconduct)
40
+
*[Open Source Initiative General Code of Conduct](https://opensource.org/codeofconduct)
41
+
*[Apache Code of Conduct](https://www.apache.org/foundation/policies/conduct.html)
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+29-18Lines changed: 29 additions & 18 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,14 +1,27 @@
1
1
Hello! Thank you for choosing to help contribute to one of the SendGrid open source libraries. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.
2
2
3
-
-[CLAs and CCLAs](#cla)
4
-
-[Roadmap & Milestones](#roadmap)
3
+
-[CLAs and CCLAs](#clas-and-cclas)
5
4
-[Feature Request](#feature-request)
6
5
-[Submit a Bug Report](#submit-a-bug-report)
6
+
-[Please use our Bug Report Template](#please-use-our-bug-report-template)
7
7
-[Improvements to the Codebase](#improvements-to-the-codebase)
8
-
-[Understanding the Code Base](#understanding-the-codebase)
# You do not need to do this when using Docker Compose
110
+
source .env
93
111
```
94
112
95
113
##### Execute: #####
@@ -122,12 +140,6 @@ All test files are in the [`test`](https://github.com/sendgrid/sendgrid-python/t
122
140
123
141
For the purposes of contributing to this repo, please update the [`test_sendgrid.py`](https://github.com/sendgrid/sendgrid-python/tree/master/test/test_sendgrid.py) file with unit tests as you modify the code.
124
142
125
-
For Python 2.6.*:
126
-
127
-
`unit2 discover -v`
128
-
129
-
For Python 2.7.* and up:
130
-
131
143
`python -m unittest discover -v`
132
144
133
145
### Testing Multiple Versions of Python
@@ -149,7 +161,6 @@ You can install it by yourself in user dir by calling `source test/prism.sh`.
149
161
Add ```eval "$(pyenv init -)"``` to your shell environment (.profile, .bashrc, etc) after installing tox, you only need to do this once.
150
162
151
163
```
152
-
pyenv install 2.6.9
153
164
pyenv install 2.7.11
154
165
pyenv install 3.4.3
155
166
pyenv install 3.5.0
@@ -159,7 +170,7 @@ Make sure to change the current working directory to your local version of the r
159
170
python setup.py install
160
171
```
161
172
```
162
-
pyenv local 3.5.0 3.4.3 2.7.11 2.6.9
173
+
pyenv local 3.5.0 3.4.3 2.7.11
163
174
pyenv rehash
164
175
```
165
176
@@ -242,4 +253,4 @@ If you have any additional questions, please feel free to [email](mailto:dx@send
242
253
243
254
<aname="code-reviews"></a>
244
255
## Code Reviews
245
-
If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how GitHub has some great [information on how to review a Pull Request](https://help.github.com/articles/about-pull-request-reviews/).
256
+
If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, GitHub has some great [information on how to review a Pull Request](https://help.github.com/articles/about-pull-request-reviews/).
If you are new to Open Source, you are at the right place to start with. Contributions are always encouraged & appreciated. Just follow the organisation's Contribution Policies & you are good to go.
3
+
## How to get Started?
4
+
-[Explore SendGrid](#explore)
5
+
-[Raise Issues(If Found Any)](#issues)
6
+
-[Setting up the Development Environment](#setup)
7
+
-[Proposing Change through a Pull Request](#pr)
8
+
-[Be Patient & Wait for reviews](#reviews)
9
+
10
+
<aname="explore"></a>
11
+
### Explore SendGrid
12
+
Step 1: Get yourself Access to SendGrid API Service absolutely free from [here](https://sendgrid.com/free/?source=sendgrid-python)\
13
+
Step 2: Get familiar with SendGrid Service
14
+
- Prerequisites are Python version 2.6, 2.7, 3.4, 3.5 or 3.6
15
+
- Set up your [SendGrid API Key](https://app.sendgrid.com/settings/api_keys) to your local workspace [using](https://github.com/sendgrid/sendgrid-python#setup-environment-variables)
16
+
- Install SendGrid to your workspace using `pip install sendgrid`
17
+
- Copy & Run few sample programs from [here](https://github.com/sendgrid/sendgrid-python#hello-email)
18
+
19
+
20
+
<aname="issues"></a>
21
+
### Raise Issues
22
+
SendGrid uses GitHub as the content management service so, all the issues related to the project be it some feature request or a bug report, all are reported at the [GitHub Issue Tracker](https://github.com/sendgrid/sendgrid-python/issues)\
23
+
Kindly make sure, to check for any duplicate issues raised by fellow contributors before opening a new issue. Be humble & polite while commenting on issues
24
+
- Feature Request\
25
+
In case you feel like something is missing or lacking in the API Service, feel free to share your views & opinions with the community
26
+
- Bug Report\
27
+
If you encounter any sort of bug or abnormal behavior, feel free to inform the community after performing the following checks:
28
+
- Update to the latest version & check if the bug persists
29
+
- Check the Issue Tracker for any similar bug report
30
+
31
+
Finally fill up the Bug Report Template & Open the Issue highlighting your encountered bug & detailed steps to regenerate the bug.
32
+
33
+
<aname="setup"></a>
34
+
### Setting up the Development Environment
35
+
-**Using Docker**\
36
+
Use our Docker image to avoid setting up the development environment yourself. See [USAGE.md](https://github.com/sendgrid/sendgrid-python/blob/master/docker/USAGE.md)
37
+
38
+
-**Setting up Locally**\
39
+
Step 1: Install the Prerequistes: Any Version of Python(2.6 through 3.6) & [python_http_client](https://github.com/sendgrid/python-http-client)\
40
+
Step 2: Get a local copy of repository using `git clone https://github.com/sendgrid/sendgrid-python.git`\
41
+
Step 3: Set your [SendGrid API Key](https://app.sendgrid.com/settings/api_keys) to your local workspace using\
Step 4: The entire codebase consist of 3 major divisions
46
+
-**/examples** contains *Working examples that demonstrate usage*
47
+
-**/tests** contains *the unit and profiling tests*
48
+
-**/sendgrid** contains *the Web API v3 client ie sendgrid.py and other files*.
49
+
50
+
51
+
<aname="pr"></a>
52
+
## Proposing Change through a Pull Request
53
+
**Step 1:** Fork the project & Clone your fork using `git clone https://github.com/<USERNAME>/sendgrid-python.git`
54
+
55
+
**Step 2:** Reconfigure the remotes using `cd sendgrid-python` and `git remote add upstream https://github.com/sendgrid/sendgrid-python.git`
56
+
57
+
**Step 3:** Create a new branch for your modifications using `git checkout -b <topic-branch-name>`
58
+
59
+
**Step 4:** Commit the changes in logical chunks & add commit messages strictly following [this](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
60
+
61
+
**Step 5:** Run all test locally, [for more info](https://github.com/sendgrid/sendgrid-python/blob/master/CONTRIBUTING.md#testing)
62
+
63
+
**Step 6:** Locally merge your the upstream development branch into your topic-branch using `git pull [--rebase] upstream master`
64
+
65
+
**Step 7:** Push the topic branch up to your fork using `git push origin <topic-branch-name>`
66
+
67
+
**Step 8:** Open a Pull Request with clear title and description against the master branch.
68
+
69
+
In case, you have additional questions, feel free to drop a [mail](dx@sendgrid.com) or open an issue.
70
+
71
+
<aname="reviews"></a>
72
+
## Be Patient & Wait for Reviews
73
+
Kindly be patient & follow the suggestions as provided by the peer reviewers. Make required ammendments & changes to the PR as asked.
74
+
75
+
## [Explore New Issues to work upon](https://github.com/sendgrid/sendgrid-python/labels/difficulty%3A%20easy)
0 commit comments