Merge pull request #141 from sendgrid/pythonic

Pythonic

Author: thinkingserious

example_v3_test.py

@@ -10,13 +10,13 @@
 
 client = sendgrid.SendGridAPIClient(os.environ.get('SENDGRID_API_KEY'))
 
+"""
+
 email = 'elmer.thomas+test_global0@gmail.com'
 status, msg = client.asm_global_suppressions.delete(email)
 print status
 print msg
 
-"""
-
 status, msg = client.suppressions.get()
 print status
 print msg
@@ -38,10 +38,6 @@
 print status
 print msg
 
-status, msg = client.asm_groups.get()
-print status
-print msg
-
 status, msg = client.asm_groups.post("Magic Key", "Unlock your Emails")
 print status
 print msg

sendgrid/resources/asm_global_suppressions.py

@@ -35,18 +35,18 @@ def client(self):
         return self._client
 
     # Determine if an email belongs to the global suppression group
-    def get(self, email=None):
+    def get(self, email):
         self._endpoint = self._base_endpoint + '/' + email
         return self.client.get(self)
 
     # Add an email to the global suppressions group
-    def post(self, emails=None):
+    def post(self, emails):
         self._endpoint = self._base_endpoint
         data = {}
         data["recipient_emails"] = emails
         return self.client.post(self, data)
 
     # Remove an email from the global suppressions group
-    def delete(self, email=None):
+    def delete(self, email):
         self._endpoint = self._base_endpoint + '/' + email
         return self.client.delete(self)

sendgrid/resources/asm_groups.py

@@ -39,19 +39,8 @@ def client(self):
     def get(self, id=None):
         if id == None:
             return self.client.get(self)
-        
-        if isinstance(id, int):
+        else:
             self._endpoint = self._base_endpoint + "/" + str(id)
-            return self.client.get(self)
-        
-        if len(id) > 1:
-            count = 0
-            for i in id:
-                if count == 0:
-                    self._endpoint = self._endpoint + "?id=" + str(i)
-                else:
-                    self._endpoint = self._endpoint + "&id=" + str(i)
-                count = count + 1
 
         return self.client.get(self)
 

sendgrid/resources/asm_suppressions.py

@@ -36,10 +36,8 @@ def client(self):
         return self._client
 
     # Get suppressed addresses for a given group id.
-    def get(self, id=None):        
-        if isinstance(id, int):
-            self._endpoint = self._base_endpoint + "/" + str(id) + "/suppressions"
-            return self.client.get(self)
+    def get(self, id):        
+        self._endpoint = self._base_endpoint + "/" + str(id) + "/suppressions"
         return self.client.get(self)
 
     # Add recipient addresses to the suppressions list for a given group.