Simplify Docker command

[thomas-mc-work]

Hello,

in your docker compose exmaple this command is required in order to start the server:

-c /config/cup.json serve

I think this could be simplified to nothing just by providing sane defaults.

1. -c /config/cup.json: This could be avoided by mounting the config to the default location. Mostly this is /etc/cup.json. The docs are referring to ~/.config/cup.json.
2. serve: this could be specified in the Dockerfile as the default command: CMD serve. This command can easily be overridden when required. But inmost cases it isn't and thus reduces the noise.

The cmd in the docker-compose.yml could thus be removed completely if the changes are implemented.

What do you think?

[sergi0g]

Hi! Thanks for the feedback!

-c /config/cup.json: This could be avoided by mounting the config to the default location. Mostly this is /etc/cup.json. The docs are referring to ~/.config/cup.json.

I chose to explicitly include the config path argument in the example, since most users will want to use a config and it helps avoiding the hassle of finding how to specify the config file location or how the Docker Compose command field works.

serve: this could be specified in the Dockerfile as the default command: CMD serve. This command can easily be overridden when required. But inmost cases it isn't and thus reduces the noise.

This one could theoretically be removed, but when specifying a config or some other option, it would have to be overridden anyway, so I don't think it's a change worth making.

I'm closing this discussion now, but feel free to reopen it if you have any objections!

[thomas-mc-work]

it helps avoiding the hassle of finding how to specify the config file location

Not sure if I get that argument. I just see all the other Docker images which are aligning to that approch . Like the one of Postgresql: The docs say mount your data folder to /var/lib/postgresql/data. This is the default path where the appöication will look for the data. No need to specify it explicitely with a command. You still can override this, but that is very rarely the case. Almost all applications and their respective images are working that way.