[BUG] UI shows duplicate images when old image is still downloaded and container is already updated

[dougmaitelli]

Describe the bug
After running cup and updating the images that were outdated the UI will still show the old images in the list alongside the new ones which can be confusing.

To Reproduce
Steps to reproduce the behavior:

1. Have some running container with outdated image
2. Check on cup for the pending update
3. Update the running container
4. Check cup again and you will see the image twice on the list

Expected behavior
I would assume we should show the image just once, if there is a running container with an image we should not show unused versions of the same image

Screenshots

System info (please complete the following information):

• OS: Alpine Linux on Proxmox VM
• Docker daemon version: 28.3.3
• Cup version: 3.4.3

Additional context
N/A

[dougmaitelli]

Hey @sergi0g, I saw your comments about not having enough time to work on the bugs right now.
So, first of all, thank you for your amazing work here.

I think this project is a great idea and has a lot of potential and I want to help if I can.
So, I am not a Rust developer but it won't hurt to try. But before going ahead and assuming the behavior described above is a bug and opening PRs for it, I decided to open this Issue to discuss.

Do you think we can just filter out images from the images array here https://github.com/sergi0g/cup/blob/main/src/check.rs#L103 if the same image (not same version) is already in the images_in_use array?

[sergi0g]

Hey @sergi0g, I saw your comments about not having enough time to work on the bugs right now.
So, first of all, thank you for your amazing work here.

I think this project is a great idea and has a lot of potential and I want to help if I can.

I really appreciate it!

So, I am not a Rust developer but it won't hurt to try.

Of course it won't, it's a great chance to learn! I'm not a Rust developer either! 😄

But before going ahead and assuming the behavior described above is a bug and opening PRs for it, I decided to open this Issue to discuss.

Good idea, because I'm about to undo what I just said:

I believe this isn't a bug, there are cases where users may want to check for updates to images that aren't actively in use and I wouldn't like to break this experience for them. To hide unused images you can simply use the filter in the dashboard (I need to add a CLI flag for this too, now that I'm thinking about it). I don't think this should be the default unless enough people ask for it.

I assume your next question will be if there's a way to automatically do this. Currently, it isn't possible but I was planning on adding support for parsing filters from the query string so you could have an easy bookmarkable URL with your presets.

I hope that covers your questions!

[dougmaitelli]

Hey @sergi0g ,

Thanks for your reply.

I was not suggesting hiding unused images, but instead hide unused images only if they have a newer version on the list.

Basically:

• if it is a running image, always show
• if it is unused then only show if it is not already on the running list and only show one entry with the highest version

Reason:

• if they already downloaded a new version of that image and it is not in use then there is nothing to be done from the update perspective

About making this a setting on the query parameters, I would personally prefer a config file than query parameters tbh.