Skip to content

fix: add ability to prefix table location for delta #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix: add ability to prefix table location for delta #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion servc/svc/com/storage/delta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(self, config: Config, table: LakeTable):
else:
self._location_prefix = os.path.join(
str(catalog_properties_raw.get("warehouse")),
str(catalog_properties_raw.get("s3.access-key-id")),
str(catalog_properties_raw.get("delta-prefix") or catalog_properties_raw.get("s3.access-key-id")),
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an AWS access key ID as a fallback for a table location prefix is questionable from a security perspective, as it exposes sensitive credentials in file paths. Consider using a dedicated configuration option or a more appropriate default value.

Suggested change
str(catalog_properties_raw.get("delta-prefix") or catalog_properties_raw.get("s3.access-key-id")),
str(catalog_properties_raw.get("delta-prefix") or "default-delta-prefix"),

Copilot uses AI. Check for mistakes.
)
self._storageOptions = {
"AWS_ACCESS_KEY_ID": str(
Expand Down
Loading