Skip to content

Convert LinqExtensionRegistration to readonly struct #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Convert LinqExtensionRegistration to readonly struct #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
355c1da
Convert `LinqExtensionRegistration` to readonly struct
SergeiPavlov Oct 31, 2025
673a8e4
Remove redundant ReferenceEquals
SergeiPavlov Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions Orm/Xtensive.Orm/Orm/Configuration/LinqExtensionRegistration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,33 +4,30 @@
// Created by: Denis Krjuchkov
// Created: 2011.10.27

using System;
using System.Linq.Expressions;
using System.Reflection;
using Xtensive.Core;


namespace Xtensive.Orm.Configuration
{
/// <summary>
/// Registration entry for LINQ extension.
/// </summary>
public sealed class LinqExtensionRegistration
public readonly struct LinqExtensionRegistration
{
/// <summary>
/// Gets member this extension is intended for.
/// </summary>
public MemberInfo Member { get; private set; }
public MemberInfo Member { get; }

/// <summary>
/// Gets substitution that is performed when LINQ translator encouters <see cref="Member"/> access.
/// </summary>
public LambdaExpression Substitution { get; private set; }
public LambdaExpression Substitution { get; }

/// <summary>
/// Gets action that is performed when LINQ translator encouters <see cref="Member"/> access.
/// </summary>
public Func<MemberInfo, Expression, Expression[], Expression> Compiler { get; private set; }
public Func<MemberInfo, Expression, Expression[], Expression> Compiler { get; }


// Constructors
Expand Down Expand Up @@ -63,4 +60,4 @@ public LinqExtensionRegistration(MemberInfo member, Func<MemberInfo, Expression,
Compiler = compiler;
}
}
}
}
3 changes: 1 addition & 2 deletions Orm/Xtensive.Orm/Orm/Linq/MemberCompilation/MemberCompilerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ internal partial class MemberCompilerProvider<T> : LockableBase, IMemberCompiler
private readonly Module module;
private readonly int metadataToken;

public bool Equals(CompilerKey other) => metadataToken == other.metadataToken
&& (ReferenceEquals(module, other.module) || module == other.module);
public bool Equals(CompilerKey other) => metadataToken == other.metadataToken && module == other.module;

public override bool Equals(object obj) => obj is CompilerKey other && Equals(other);

Expand Down