Merge branch 'main' into no_std

Author: domenukk

.github/workflows/main.yml

@@ -55,7 +55,8 @@ jobs:
         if: |
           matrix.os == 'windows-latest' &&
           matrix.rust != '1.56.0'
-        run: cargo test --test debugger_visualizer --features "url/debugger_visualizer,url_debug_tests/debugger_visualizer" -- --test-threads=1
+        run: cargo test --test debugger_visualizer --features "url/debugger_visualizer,url_debug_tests/debugger_visualizer" -- --test-threads=1 || echo "debugger test failed"
+        continue-on-error: true # Fails on GH actions, but not locally.
       - name: Test `no_std` support
         run: cargo test --no-default-features --features=alloc
       - name: Build `url` crate for `aarch64-unknown-none` with `no_std`

idna/src/punycode.rs

@@ -324,6 +324,10 @@ fn value_to_digit(value: u32) -> char {
 #[cfg(target_pointer_width = "64")]
 fn huge_encode() {
     let mut buf = String::new();
-    assert!(encode_into(std::iter::repeat('ß').take(u32::MAX as usize + 1), &mut buf).is_err());
+    assert!(encode_into(
+        core::iter::repeat('ß').take(u32::MAX as usize + 1),
+        &mut buf
+    )
+    .is_err());
     assert_eq!(buf.len(), 0);
 }

url/src/lib.rs

@@ -148,6 +148,9 @@ url = { version = "2", features = ["debugger_visualizer"] }
     feature = "debugger_visualizer",
     debugger_visualizer(natvis_file = "../../debug_metadata/url.natvis")
 )]
+// We use std::os::wasi::prelude::OsStrExt, and that is conditionally feature gated
+// to be unstable on wasm32-wasip2. https://github.com/rust-lang/rust/issues/130323
+#![cfg_attr(all(target_os = "wasi", target_env = "p2"), feature(wasip2))]
 
 pub use form_urlencoded;
 
@@ -407,10 +410,10 @@ impl Url {
     /// # Notes
     ///
     /// - A trailing slash is significant.
-    /// Without it, the last path component is considered to be a “file” name
-    /// to be removed to get at the “directory” that is used as the base.
+    ///   Without it, the last path component is considered to be a “file” name
+    ///   to be removed to get at the “directory” that is used as the base.
     /// - A [scheme relative special URL](https://url.spec.whatwg.org/#scheme-relative-special-url-string)
-    /// as input replaces everything in the base URL after the scheme.
+    ///   as input replaces everything in the base URL after the scheme.
     /// - An absolute URL (with a scheme) as input replaces the whole base URL (even the scheme).
     ///
     /// # Examples