fix(cli): view of zarr data #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-silversmith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197
Semiclean solution for #197.
I call it "semiclean" because think a cleaner approach may be to modify the logic of paths in
cloudvolume. For instance this line is reached: https://github.com/seung-lab/cloud-volume/blob/74b3496d0d3a906cde6cac1d39fc3928360cfa93/cloudvolume/cloudvolume.py#L255 but the returned value is still aCloudVolumeobject such thatcv.meta.path.format == 'precomputed', while I would expectcv.meta.path.format == 'zarr2'Since, since the PR only makes minimal changes, and only in the CLI function
view()(which is therefore not called by other parts of the code), this workaround may be good enough.