Fix overload resolution for sized arrays to unsized array parameters #9087
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that canCoerce() called _coerce() with CoercionSite::General during overload resolution, but the sized-to-unsized array conversion logic only worked when CoercionSite::Argument was used. This caused overload candidates to be incorrectly rejected even though the conversion would work during the actual coercion phase. Changes: - Add overload of canCoerce() that accepts CoercionSite parameter - Update TryCheckOverloadCandidateTypes to use CoercionSite::Argument - Add comprehensive test case for array overload resolution Fixes #9060 Co-authored-by: pdeayton-nv <pdeayton-nv@users.noreply.github.com>
csyonghe
requested changes
Dec 2, 2025
Collaborator
csyonghe
left a comment
csyonghe
left a comment
There was a problem hiding this comment.
We should implement the cache key fix suggested by @tangent-vector's comment in #9060.
Collaborator
|
@kaizhangNV , can you address what Yong and Tess suggested. |
Contributor
Author
|
I did not own this issue, Peter did. I just click the button to create the PR from Claude. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9060
The issue was that
canCoerce()called_coerce()withCoercionSite::Generalduring overload resolution, but the sized-to-unsized array conversion logic only worked whenCoercionSite::Argumentwas used. This caused overload candidates to be incorrectly rejected even though the conversion would work during the actual coercion phase.Changes
canCoerce()that acceptsCoercionSiteparameterTryCheckOverloadCandidateTypesto useCoercionSite::Argument📝 Generated with Claude Code