From b8e0995dcf04a134a01925a386c397a8a66a0b57 Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Fri, 21 Nov 2025 09:57:36 +0200 Subject: [PATCH 1/7] Copy Falcor .git directory for VCS detection Falcor test scripts require .git repository to detect VCS root. --- .github/workflows/falcor-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index 93f8eb57728..d16cee93240 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -52,6 +52,7 @@ jobs: mkdir FalcorBin cd FalcorBin Copy-Item -Path 'C:\Falcor\build\windows-vs2022\bin' -Destination '.\build\windows-vs2022\bin' -Recurse -Exclude ("*.pdb") + Copy-Item -Path 'C:\Falcor\.git' -Destination '.\' -Recurse Copy-Item -Path 'C:\Falcor\tests' -Destination '.\' -Recurse Copy-Item -Path 'C:\Falcor\tools' -Destination '.\' -Recurse Copy-Item -Path 'C:\Falcor\media' -Destination '.\' -Recurse From c06090efed0852a8c79f265e1933f2dd06b8a0e1 Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Fri, 21 Nov 2025 11:58:09 +0200 Subject: [PATCH 2/7] Fix Falcor test tags argument parsing Use --tags= syntax to prevent argument misparsing. --- .github/workflows/falcor-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index d16cee93240..abd363e12e8 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -77,7 +77,7 @@ jobs: run: | $ErrorActionPreference = "SilentlyContinue" cd .\FalcorBin\tests - python ./testing/run_unit_tests.py --config windows-vs2022-Release -t "-slow" + python ./testing/run_unit_tests.py --config windows-vs2022-Release --tags="-slow" cd ../../ - name: falcor-image-test shell: pwsh From d2b209d11a7ee4068ff9f937866284e69e04723c Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Fri, 21 Nov 2025 13:44:56 +0200 Subject: [PATCH 3/7] Add workflow_dispatch trigger to Falcor tests --- .github/workflows/falcor-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index abd363e12e8..dd384393f87 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -9,6 +9,7 @@ on: - "LICENSE" - "CONTRIBUTING.md" - "README.md" + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true From fbd8cf5c86aa5b485e343cc94390e9d509edd7a3 Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Fri, 21 Nov 2025 13:46:00 +0200 Subject: [PATCH 4/7] Change to dbg label temporarily --- .github/workflows/falcor-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index dd384393f87..68fc89de46c 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -29,7 +29,7 @@ jobs: - warnings-as-errors: true test-category: full full-gpu-tests: false - runs-on: [Windows, self-hosted, falcor] + runs-on: [Windows, self-hosted, falcordbg] runs-on: ${{ matrix.runs-on }} defaults: run: From d5bde22615f3f2f564cedf4508cd38217414040f Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Fri, 21 Nov 2025 14:45:14 +0200 Subject: [PATCH 5/7] Add debug output for Falcor unit test failures List exe/dll files, check for FalcorTest.exe and .git directory. --- .github/workflows/falcor-test.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index 68fc89de46c..1b3df9b79b4 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -76,9 +76,16 @@ jobs: - name: falcor-unit-test shell: pwsh run: | - $ErrorActionPreference = "SilentlyContinue" + $ErrorActionPreference = "Continue" + Write-Host "=== Listing FalcorBin structure ===" + Get-ChildItem -Recurse -Force .\FalcorBin | Where-Object { $_.Extension -eq ".exe" -or $_.Extension -eq ".dll" -or $_.Name -eq ".git" } | Select-Object FullName + Write-Host "=== Checking for FalcorTest.exe ===" + Get-ChildItem -Recurse .\FalcorBin\build -Filter "FalcorTest.exe" -ErrorAction SilentlyContinue | Select-Object FullName + Write-Host "=== Checking .git directory ===" + Test-Path .\FalcorBin\.git + Write-Host "=== Running unit tests ===" cd .\FalcorBin\tests - python ./testing/run_unit_tests.py --config windows-vs2022-Release --tags="-slow" + python -u ./testing/run_unit_tests.py --config windows-vs2022-Release --tags="-slow" cd ../../ - name: falcor-image-test shell: pwsh From 42ef282fc5a62abc1a06a2cd9e3fba90819f2ee3 Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Mon, 24 Nov 2025 13:20:49 +0200 Subject: [PATCH 6/7] Copy FalcorBin to C:\FalcorDebug for post-mortem analysis Timestamped copies saved after each run for debugging. --- .github/workflows/falcor-test.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index 1b3df9b79b4..77ea44ff1b6 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -87,6 +87,16 @@ jobs: cd .\FalcorBin\tests python -u ./testing/run_unit_tests.py --config windows-vs2022-Release --tags="-slow" cd ../../ + - name: Copy FalcorBin for debugging + if: always() + shell: pwsh + run: | + $timestamp = Get-Date -Format "yyyy-MM-dd_HH-mm-ss" + $debugDir = "C:\FalcorDebug\$timestamp" + Write-Host "Copying FalcorBin to $debugDir for debugging" + New-Item -ItemType Directory -Force -Path $debugDir + Copy-Item -Path .\FalcorBin -Destination $debugDir -Recurse -Force + Write-Host "Debug copy saved to: $debugDir" - name: falcor-image-test shell: pwsh run: | From f643c669f6e5be02a9d3ce5344d5bad1c6398431 Mon Sep 17 00:00:00 2001 From: "Janne Kiviluoto (NVIDIA)" <235827468+jkiviluoto-nv@users.noreply.github.com> Date: Mon, 24 Nov 2025 14:01:08 +0200 Subject: [PATCH 7/7] Add verbose logging for unit test execution Capture exit code and output to diagnose silent failures. --- .github/workflows/falcor-test.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/falcor-test.yml b/.github/workflows/falcor-test.yml index 77ea44ff1b6..fd11977b205 100644 --- a/.github/workflows/falcor-test.yml +++ b/.github/workflows/falcor-test.yml @@ -85,8 +85,15 @@ jobs: Test-Path .\FalcorBin\.git Write-Host "=== Running unit tests ===" cd .\FalcorBin\tests - python -u ./testing/run_unit_tests.py --config windows-vs2022-Release --tags="-slow" + Write-Host "Command: python -u ./testing/run_unit_tests.py --config windows-vs2022-Release --tags=`"-slow`"" + Write-Host "Working directory: $PWD" + $env:PYTHONUNBUFFERED = "1" + python -u ./testing/run_unit_tests.py --config windows-vs2022-Release --tags="-slow" 2>&1 | Tee-Object -Variable output + $exitCode = $LASTEXITCODE + Write-Host "Exit code: $exitCode" + Write-Host "Output length: $($output.Length) lines" cd ../../ + if ($exitCode -ne 0) { exit $exitCode } - name: Copy FalcorBin for debugging if: always() shell: pwsh