Add Windows ARM64 support #567
Conversation
guoxx
commented
Oct 12, 2025
guoxx
commented
- Adds CMake presets for the MSVC ARM64 toolchain.
- Updates setup.py to detect and configure for the ARM64 architecture.
- Makes warnings-as-errors optional to handle platform-specific warnings.
- Adjusts ci.py to recognize the new platform.
|
|
* Adds CMake presets for the MSVC ARM64 toolchain. * Updates setup.py to detect and configure for the ARM64 architecture. * Makes warnings-as-errors optional to handle platform-specific warnings. * Adjusts ci.py to recognize the new platform.
skallweitNV
left a comment
skallweitNV
left a comment
There was a problem hiding this comment.
LGTM, we should probably also add support for linux on arm64
As far as I know, ARM64 support for Linux is already in progress and actively discussed in issue #457. |
|
I noticed a code conflict with recent changes on the slangpy main branch. |
|
Hi @guoxx , please resolve the conflict in this PR and I can +1 again |
|
Hi @gtong-nv , I've resolved the conflict and verified it on the Windows ARM platform. Thank you for your guidance. |
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
Looks good to me.
But I am not sure about the workaround for slang-llvm.dll on ARM64 Windows.
| # slang-llvm.dll is available in x64 prebuilt packages but not in ARM64 packages. | ||
| # Use conditional copy to support both architectures. | ||
| if(EXISTS ${SLANG_DIR}/bin/slang-llvm.dll) | ||
| sgl_copy_binary(${SLANG_DIR}/bin/slang-llvm.dll .) | ||
| endif() |
There was a problem hiding this comment.
I am not sure if this is still the case.
I think we fixed a problem similar to this recently.
shader-slang/slang#8580
@guoxx , can you re-test if it works without this workaround?
There was a problem hiding this comment.
I've checked the latest Slang Windows ARM release, and slang-llvm.dll is still not included in the build.
5 participants
