Skip to content

Fix PyPi URL #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Conversation

joeyagreco
Copy link
Contributor

@joeyagreco joeyagreco commented Jan 19, 2025

Before, the PyPi URL was always giving a false positive.

The new URL fixes that issue.

old url

curl -o /dev/null -s -w "%{http_code}\n" https://pypi.org/user/real_pypi_username
200 

curl -o /dev/null -s -w "%{http_code}\n" https://pypi.org/user/fake_pypi_username
200

new url

curl -o /dev/null -s -w "%{http_code}\n" https://pypi.org/_includes/administer-user-include/real_pypi_username
200

curl -o /dev/null -s -w "%{http_code}\n" https://pypi.org/_includes/administer-user-include/fake_pypi_username
404

#2313

Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to move your url to urlProbe rather than urlMain, but the new url works as intended

LGTM! Thanks for the contribution

@ppfeister ppfeister merged commit a688e26 into sherlock-project:master Feb 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants