Moving `ApplyContentTransforms` from rendering function to `mapToModel` function

[josejibin]

We do some transformations to the film/tv/bonus/collection's overview before rendering.
This transformation includes adding the markdown, sanitization, and shortcode rendering.

We are doing this in two places for the same content—one in FilmDataSource and another in FilmIndexDataSource.

I wondered if we could move it into a single place, probably while converting an item into a model after fetching it via API.

Why?

• We don't have to do the same thing in two places.
• We are mutating the film data. This holds us back from rendering the templates parallelly. ( a good to have future change)

Question.

If we want to do it in mapToModel, we must load the shortcode templates before. (Which we are already doing, by the way). This will make the API package depends on template loading. We are not using the APIs anywhere other than for template rendering though.

So is this a deal-breaker? Can I submit a PR for the same?

[stajs]

Sounds reasonable to me. Could it be as simple as calling ApplyContentTransforms on the Overview for both films and bonus content?

Tagging @brynyShift72 @PeculiarGoat for thoughts.

[sarge]

It is a good question. I can't recall any explicit decision around this.
Things to consider, localization?

[PeculiarGoat]

Also sounds reasonable to me. Do any of the other datasources have this issue?

[brynyShift72]

Sounds good to me