diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..d5a6a311 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,17 @@ +## Goal +Set up SSH commit signing and add a PR template for Lab 1. + +## Changes +- Configured SSH commit signing in git. +- Added minimal pull request template at `.github/pull_request_template.md`. +- Created `labs/submission1.md` with answers and screenshots. + +## Testing +- Created a signed commit, checked that it is marked "Verified" on GitHub. +- Opened a new pull request and confirmed that the template appears automatically. + +## Checklist +- [x] Clear, descriptive PR title +- [x] Documentation/README updated if needed +- [x] No secrets or large temporary files committed + diff --git a/labs/screenshots/pr_template_autofill.png b/labs/screenshots/pr_template_autofill.png new file mode 100644 index 00000000..ea944ad4 Binary files /dev/null and b/labs/screenshots/pr_template_autofill.png differ diff --git a/labs/screenshots/verified_commit.png b/labs/screenshots/verified_commit.png new file mode 100644 index 00000000..9e60475c Binary files /dev/null and b/labs/screenshots/verified_commit.png differ diff --git a/labs/submission1.md b/labs/submission1.md index b7feb771..09ae158f 100644 --- a/labs/submission1.md +++ b/labs/submission1.md @@ -25,3 +25,29 @@ user.signingkey=/Users/shiyanovn/.ssh/id_ed25519.pub ### 3. Why is Commit Signing Important in DevOps Workflows? In DevOps, many people work on the same code. Signed commits help us know exactly who made each change. It stops attackers or mistakes from unknown people, and is required for security in many companies. + + +--- + +[My signed commit](https://github.com/shiyanovn/DevOps-Intro/commit/d3059b65be7140413647905435e988f4705540a0) + +![Verified commit screenshot](screenshots/verified_commit.png) +--- + +## Task 2: PR Template & Checklist + +### 1. PR Template Location + +File `.github/pull_request_template.md` is created in the main branch. + +### 2. Screenshot of PR Template Auto-fill + +![PR template autofill screenshot](screenshots/pr_template_autofill.png) + +### 3. How PR Templates Help + +PR templates help teams to remember all important information for every pull request. It makes review easier and reduces mistakes. + +### 4. Challenges + +At first, the template did not appear because I created PR before adding the file to main. I learned the template must be in main before PR.