refactor: streamline media deletion process in deleteMedia hook

Author: ArseniyX

src/collections/Products/hooks/delete-media.ts

@@ -1,14 +1,14 @@
 import type { Media, Product } from "@/payload-types";
 import type { AfterDeleteHook } from "node_modules/payload/dist/collections/config/types";
-import type { BasePayload } from "payload";
 
 import { isExpandedDoc } from "@/utils/is-expended-doc";
 
 export const deleteMedia: AfterDeleteHook<Product> = async ({ doc, req }) => {
     const { payload } = req;
-
     req.payload.logger.debug(`Starting to delete media for product: ${doc.id}`);
 
+    const mediaMap = new Map<string, Media>();
+
     for (const variant of doc.variants) {
         if (!variant.gallery) {
             req.payload.logger.debug(`Skipping variant - no gallery found`);
@@ -17,29 +17,50 @@ export const deleteMedia: AfterDeleteHook<Product> = async ({ doc, req }) => {
 
         req.payload.logger.debug(`Processing gallery deletion for variant`);
 
-        await deleteGalleryImages(variant.gallery, payload);
+        for (const image of variant.gallery) {
+            if (isExpandedDoc<Media>(image)) {
+                if (!mediaMap.has(image.filename)) {
+                    mediaMap.set(image.filename, image);
+                } else {
+                    req.payload.logger.debug(
+                        `Duplicate filename detected, skipping: ${image.filename}`
+                    );
+                }
+            } else {
+                req.payload.logger.debug(`Skipping image - not expanded`);
+            }
+        }
     }
-};
 
-async function deleteGalleryImages(
-    gallery: (Media | number)[],
-    payload: BasePayload
-) {
-    payload.logger.debug(`Deleting gallery images, count: ${gallery.length}`);
+    const uniqueImages = Array.from(mediaMap.values());
 
-    for (const image of gallery) {
-        if (!isExpandedDoc<Media>(image)) {
-            payload.logger.debug(`Skipping image - no access to filename`);
-            continue;
-        }
-        payload.logger.debug(`Deleting media with filename: ${image.filename}`);
-        await payload.delete({
-            collection: "media",
-            where: {
-                filename: {
-                    equals: image.filename,
-                },
-            },
-        });
-    }
-}
+    req.payload.logger.debug(
+        `Deleting ${uniqueImages.length} unique media files`
+    );
+
+    const deletionResults = await Promise.allSettled(
+        uniqueImages.map((image) =>
+            payload
+                .delete({
+                    id: image.id,
+                    collection: "media",
+                    req,
+                })
+                .then(() => {
+                    payload.logger.debug(
+                        `Successfully deleted: ${image.filename}`
+                    );
+                })
+                .catch((error) => {
+                    payload.logger.error(
+                        `Failed to delete: ${image.filename}`,
+                        error
+                    );
+                })
+        )
+    );
+
+    req.payload.logger.debug(
+        `Deletion results: ${JSON.stringify(deletionResults)}`
+    );
+};