Forwarded For

[pkamps]

Hi there,

disclaimer: it's the first time I try to hack on C code to please forgive me for my lack of knowledge.

I have a question about this code:

apr_table_get(r->headers_in, "X-Forwarded-For")

I know the X-Forwarded-For header can have a list of IPs (comma separted). As far as I can tell, you set the X-Forwarded-For to the 'remote_ip' variable. The remote_ip is supposed to be a single IP, right?
So, as long as the X-Forwarded-For header is a single IP it works, correct?

[shukob]

Hi,

thank you for pointing me this.
You are correct. I did not realize how X-Forwarded-For works until now.

So this is currently only useful on 1 proxy case, as it contains client IP.
This will be improved by splitting and extracting first entry from X-Forwarded-For in that code.

[mmucklo]

Quick question - for X-Forwarded-For can't one just use:

# Apache 2.4 syntax (2.2 would use mod_rpaf and something similar)
LoadModule remoteip_module modules/mod_remoteip.so
RemoteIPHeader X-Forwarded-For

[shukob]

Hi, thanks for the suggestion!

I did not know about mod_remoteip and mod_rpaf so far, but googled them.
mod_rpaf would change remote_ip so it can be used here for 2.2.

Apache 2.4 seems to rename request_rec->connection->remote_ip to 'client_ip' and mod_remoteip sets 'useragent_ip' instead of client_ip for real user-end ip, so first, this module might not be compiled against 2.4, and if someone will, he need to rewrite it to change remote_ip to client_ip/useragent_ip.

*I didn't check this with hands.