fixup! ASoC: SOF: debug_dsp_ops: Add op to test DSP power state changes

bardliao · ranj063 · commit 9d8dbf80cfb6 · 2025-01-14T10:02:31.000-08:00
Reported by analyzer-use-of-uninitialized-value
sound/soc/sof/debug-dsp-ops.c:216:19: error: use of uninitialized value
‘string’ [CWE-457] [-Werror=analyzer-use-of-uninitialized-value]

The ‘string’ will not be assigned in the default case of switch
(sdev-&gt;dsp_power_state.state) and (sdev-&gt;dsp_power_state.substate).

Signed-off-by: Bard Liao &lt;yung-chuan.liao@linux.intel.com&gt;
diff --git a/sound/soc/sof/debug-dsp-ops.c b/sound/soc/sof/debug-dsp-ops.c
@@ -177,8 +177,8 @@ static ssize_t sof_dsp_ops_tester_dfs_read(struct file *file, char __user *buffe
 {
 	struct snd_sof_dfsentry *dfse = file->private_data;
 	struct snd_sof_dev *sdev = dfse->sdev;
+	const char *string = NULL;
 	struct dentry *dentry;
-	const char *string;
 	size_t size_ret;
 
 	/* return the FW filename or path */

Original file line number	Diff line number	Diff line change
`@@ -177,8 +177,8 @@ static ssize_t sof_dsp_ops_tester_dfs_read(struct file file, char __user buffe`
`177`	`177`	`{`
`178`	`178`	`struct snd_sof_dfsentry *dfse = file->private_data;`
`179`	`179`	`struct snd_sof_dev *sdev = dfse->sdev;`
	`180`	`+ const char *string = NULL;`
`180`	`181`	`struct dentry *dentry;`
`181`		`- const char *string;`
`182`	`182`	`size_t size_ret;`
`183`	`183`
`184`	`184`	`/* return the FW filename or path */`