Skip to content

Commit 0b5f6ff

Browse files
authored
Update README.md
1 parent e12a6d3 commit 0b5f6ff

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ There are a few caveats about its usage as compared to other clients due to diff
5858
* There is no support for read and write timeouts, per [JDK-8258397](https://bugs.openjdk.org/browse/JDK-8258397). Rather, the client can be configured to use a request timeout, which limits how long the client waits until HTTP response headers are received, but that's it.
5959
* Proxy authentication is not supported out of the box. Per [JDK-8229962](https://bugs.openjdk.org/browse/JDK-8229962), configuring proxy authentication on `HttpClient` requires providing some process-level configuration parameters up front, so proxy authentication is [up to the user](https://stackoverflow.com/a/60170227/2103602), at least for now.
6060
* There is a difference in behavior for canceled HTTP requests between Java 11 and Java 15, and Java 16 and later. Per [JDK-8245462](https://bugs.openjdk.org/browse/JDK-8245462), before Java 16, calling `CompletableFuture#cancel(boolean)` on the result of `execute()` does nothing, whereas starting with Java 16 it now attempts to cancel the request in-flight.
61-
* The client does not close connections after receiving 5XX responses from the server, which is technically part of the requirements for other HTTP clients.
61+
* The client does not close connections after receiving 5XX responses from the server, which is technically part of the requirements for other HTTP clients. The reason for the requirement is not documented, so it's not clear what negative effect(s) this difference will have in practice, if any.
6262
* There may be some slight differences in how `Expect: 100-continue` is handled versus other clients.
6363

6464
## Prior Art
@@ -72,8 +72,6 @@ They generally appear to be abandoned, which is why I created this project.
7272

7373
## Help Wanted
7474

75-
So you want to help, huh? Outstanding!
76-
77-
The most important work happening right now is determining the list of tests required for the asynchronous client. Please check out [#2](https://github.com/sigpwned/aws-java-sdk-v2-java-nio-client/issues/2) for instructions on how to contribute.
75+
All feedback -- even if it's just "I tried it, and it worked" -- is welcome, appreciated, and useful! Issues and PRs are even better.
7876

7977
Naturally, all helpers will be added to the [contributors](https://github.com/sigpwned/aws-java-sdk-v2-java-nio-client/blob/main/CONTRIBUTORS.md).

0 commit comments

Comments
 (0)