fix #36 Links don't work in numbered lists or callouts

Author: hatton

src/plugins/CalloutTransformer.spec.ts

@@ -43,3 +43,70 @@ test("smoketest callout", async () => {
   results = await blocksToMarkdown(config, [block as unknown as NotionBlock]);
   expect(results).toContain(":::info");
 });
+
+test("external link inside callout, bold preserved", async () => {
+  const config = { plugins: [standardCalloutTransformer] };
+  const results = await blocksToMarkdown(config, [
+    {
+      type: "callout",
+      callout: {
+        rich_text: [
+          {
+            type: "text",
+            text: { content: "Callouts inline ", link: null },
+            annotations: {
+              bold: false,
+              italic: false,
+              strikethrough: false,
+              underline: false,
+              code: false,
+              color: "default",
+            },
+            plain_text: "Callouts inline ",
+            href: null,
+          },
+          {
+            type: "text",
+            text: {
+              content: "great page",
+              link: { url: `https://github.com` },
+            },
+            annotations: {
+              bold: true,
+              italic: false,
+              strikethrough: false,
+              underline: false,
+              code: false,
+              color: "default",
+            },
+            plain_text: "great page",
+            href: `https://github.com`,
+          },
+          {
+            type: "text",
+            text: { content: ".", link: null },
+            annotations: {
+              bold: false,
+              italic: false,
+              strikethrough: false,
+              underline: false,
+              code: false,
+              color: "default",
+            },
+            plain_text: ".",
+            href: null,
+          },
+        ],
+        icon: { type: "emoji", emoji: "⚠️" },
+        color: "gray_background",
+      },
+    } as unknown as NotionBlock,
+  ]);
+  expect(results.trim()).toBe(
+    `:::caution
+
+Callouts inline [**great page**](https://github.com).
+
+:::`
+  );
+});

src/plugins/CalloutTransformer.ts

@@ -31,8 +31,7 @@ export async function notionCalloutToAdmonition(
 
     plain_text = notionToMarkdown.annotatePlainText(plain_text, annotations);
 
-    // if (content["href"])
-    //   plain_text = md.link(plain_text, content["href"]);
+    if (content["href"]) plain_text = `[${plain_text}](${content["href"]})`;
 
     parsedData += plain_text;
   });

src/plugins/NumberedListTransformer.spec.ts

@@ -0,0 +1,78 @@
+import { NotionBlock } from "../config/configuration";
+import { blocksToMarkdown } from "../TestRun";
+import { standardNumberedListTransformer } from "./NumberedListTransformer";
+
+let block: any;
+beforeEach(() => {
+  block = {
+    has_children: false,
+    archived: false,
+    type: "callout",
+    callout: {
+      rich_text: [
+        {
+          type: "text",
+          text: { content: "This is information callout", link: null },
+          annotations: {
+            bold: false,
+            italic: false,
+            strikethrough: false,
+            underline: false,
+            code: false,
+            color: "default",
+          },
+          plain_text: "This is the callout",
+          href: null,
+        },
+      ],
+      icon: { type: "emoji", emoji: "ℹ️" },
+      color: "gray_background",
+    },
+  };
+});
+
+test("external link inside numbered list, italic preserved", async () => {
+  const config = { plugins: [standardNumberedListTransformer] };
+  const results = await blocksToMarkdown(config, [
+    {
+      type: "numbered_list_item",
+      numbered_list_item: {
+        rich_text: [
+          {
+            type: "text",
+            text: { content: "link ", link: null },
+            annotations: {
+              bold: false,
+              italic: false,
+              strikethrough: false,
+              underline: false,
+              code: false,
+              color: "default",
+            },
+            plain_text: "link ",
+            href: null,
+          },
+          {
+            type: "text",
+            text: {
+              content: "github",
+              link: { url: "https://github.com" },
+            },
+            annotations: {
+              bold: false,
+              italic: true,
+              strikethrough: false,
+              underline: false,
+              code: false,
+              color: "default",
+            },
+            plain_text: "github",
+            href: "https://github.com",
+          },
+        ],
+        color: "default",
+      },
+    } as unknown as NotionBlock,
+  ]);
+  expect(results.trim()).toBe(`1. link [_github_](https://github.com)`);
+});

src/plugins/NumberedListTransformer.ts

@@ -23,9 +23,9 @@ export function numberedListTransformer(
 
     plain_text = notionToMarkdown.annotatePlainText(plain_text, annotations);
 
-    // if (content["href"])
-    //   plain_text = md.link(plain_text, content["href"]);
-
+    if (content["href"]) {
+      plain_text = `[${plain_text}](${content["href"]})`;
+    }
     parsedData += plain_text;
   });