feat: For Markdown files names, use explicit slugs when available

Author: hatton

src/HierarchicalNamedLayoutStrategy.ts

@@ -32,13 +32,20 @@ export class HierarchicalNamedLayoutStrategy extends LayoutStrategy {
       "/" +
       page.context +
       "/" +
-      sanitize(page.nameOrTitle) +
+      sanitize(page.nameForFile()) +
       extensionWithDot;
 
     path = path
       .replaceAll("//", "/")
       .replaceAll("%20", "-")
-      .replaceAll(" ", "-");
+      .replaceAll(" ", "-")
+      // crowdin complains about some characters in file names. I haven't found
+      // the actual list, so these are from memory.
+      .replaceAll('"', "")
+      .replaceAll("“", "")
+      .replaceAll("”", "")
+      .replaceAll("'", "")
+      .replaceAll("?", "-");
     // console.log(
     //   `getPathForPage(${context}, ${pageId}, ${title}) with  root ${this.rootDirectory} --> ${path}`
     // );

src/NotionPage.ts

@@ -90,6 +90,15 @@ export class NotionPage {
     return this.type === PageType.DatabasePage ? this.name : this.title;
   }
 
+  public nameForFile(): string {
+    // In Notion, pages from the Database have names and simple pages have titles.
+    return this.type === PageType.Simple
+      ? this.title
+      : // if it's a Database page, then we'll use the slug unless there is none, then we'd rather have the
+        // page name than an ugly id for the file name
+        this.explicitSlug()?.replace(/^\//, "") || this.name;
+  }
+
   // TODO: let's go farther in hiding this separate title vs name stuff. This seems like an implementation detail on the Notion side.
 
   // In Notion, pages from the Outline have "title"'s.