special chars é á ...

[martinschenk]

Hi,

if your write in hello-world.rtf for example
the word "tést" it works well,

but if you write for example
aáa eáe eée wáe
it delivers
aบ eพ eພ wพ

so, of there are for example "aáa" together it comes out as "aบ"
Would be great to get that fixed.

the script is very good, GREAT WORK!
Regards, Martin

[jthomerson]

@martinschenk thanks for the report. Could you please provide a test case with your report? Or, if you feel like providing one, we would be happy to review a pull request that adds a unit test for this (and even better, a fix if you'd like).

[martinschenk]

Hola Jeremy,

thank you for the fast answer.

The easiest test is to use from your sample hello-world.rtf

and to write inside:
tést aáa

thats all - you will see, that the word tést is converted OK because the
"s" after the é is not part of HEX code (a-f0-9)

aáa will be converted to a because the 3. a is part of hex regexp.

rtf code:
t'e9st a'e1a

result code:
tést aบ

I think it happens, because e1a is interpreted like one hex value.
But it shoudl be only e1 = á y another char is the a.

Didn't find out how to fix it up to now.

Regards, Martin

2015-05-22 3:53 GMT+02:00 Jeremy Thomerson notifications@github.com:

@martinschenk https://github.com/martinschenk thanks for the report.
Could you please provide a test case with your report? Or, if you feel like
providing one, we would be happy to review a pull request that adds a unit
test for this (and even better, a fix if you'd like).

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

[martinschenk]

Hi,
Test Case for this would be to run RTFDocumentTest.php "testExtractText()" with the hello-world.rtf.
Add add the en of hello-world.rtf
tést aáa
which is: t'e9st a'e1a

and at the end of hello-world.txt
téxt aáa

Regards, Martin

[martinschenk]

found a way to fix the problem.
in RTFTokenizer.php replace

    while (preg_match($paramEncoding, $this->reader->lookAhead())) {
        $param .= $this->reader->readByte();
    }

with

    $c=1;
    while (preg_match($paramEncoding, $this->reader->lookAhead())) {
        if($isHex && $c > 2){
            break;
        }
        $param .= $this->reader->readByte();
        $c++;
    }

Regards, Martin