Add batching, chunking, skipping errors and failures

Author: simonhamp

src/Http/Controllers/ImportController.php

@@ -72,19 +72,14 @@ public function import(NovaRequest $request, $file)
             ->setAttributes($attributes)
             ->setAttributeMap($attribute_map)
             ->setRules($rules)
-            ->setModelClass($model_class);
-
-        try {
-            $this->importer->import($this->getFilePath($file), null, 'Csv');
-        } catch (QueryException $e) {
-            throw new \Exception($e->getPrevious()->errorInfo[2]);
-        } catch (ImportException $e) {
-            $this->responseError($e->getMessage());
-        } catch (NoTypeDetectedException $e) {
-            $this->responseError(__('Invalid file type'));
+            ->setModelClass($model_class)
+            ->import($this->getFilePath($file), null, 'Csv');
+
+        if (! $this->importer->failures()->isEmpty() || ! $this->importer->errors()->isEmpty()) {
+            return response()->json(['result' => 'failure', 'errors' => $this->importer->errors(), 'failures' => $this->importer->failures()]);
         }
 
-        return response()->json(['result' => 'success', ]);
+        return response()->json(['result' => 'success']);
     }
 
     protected function extractValidationRules($request, NovaResource $resource)

src/Importer.php

@@ -5,12 +5,18 @@
 use Laravel\Nova\Resource;
 use Maatwebsite\Excel\Concerns\ToModel;
 use Maatwebsite\Excel\Concerns\Importable;
+use Maatwebsite\Excel\Concerns\SkipsErrors;
+use Maatwebsite\Excel\Concerns\SkipsOnError;
+use Maatwebsite\Excel\Concerns\SkipsFailures;
+use Maatwebsite\Excel\Concerns\SkipsOnFailure;
 use Maatwebsite\Excel\Concerns\WithHeadingRow;
 use Maatwebsite\Excel\Concerns\WithValidation;
+use Maatwebsite\Excel\Concerns\WithBatchInserts;
+use Maatwebsite\Excel\Concerns\WithChunkReading;
 
-class Importer implements ToModel, WithValidation, WithHeadingRow
+class Importer implements ToModel, WithValidation, WithHeadingRow, WithBatchInserts, WithChunkReading, SkipsOnFailure, SkipsOnError
 {
-    use Importable;
+    use Importable, SkipsFailures, SkipsErrors;
 
     /** @var Resource */
     protected $resource;
@@ -19,6 +25,31 @@ class Importer implements ToModel, WithValidation, WithHeadingRow
     protected $rules;
     protected $model_class;
 
+    public function model(array $row)
+    {
+        [$model, $callbacks] = $this->resource::fill(
+            new ImportRequest($this->mapRowDataToAttributes($row)),
+            $this->resource::newModel()
+        );
+
+        return $model;
+    }
+
+    public function rules(): array
+    {
+        return $this->rules;
+    }
+
+    public function batchSize(): int
+    {
+        return 100;
+    }
+
+    public function chunkSize(): int
+    {
+        return 100;
+    }
+
     /**
      * @return mixed
      */
@@ -57,11 +88,6 @@ public function setAttributeMap($map)
         return $this;
     }
 
-    public function rules(): array
-    {
-        return $this->rules;
-    }
-
     /**
      * @param mixed $rules
      * @return Importer
@@ -92,16 +118,6 @@ public function setModelClass($model_class)
         return $this;
     }
 
-    public function model(array $row)
-    {
-        [$model, $callbacks] = $this->resource::fill(
-            new ImportRequest($this->mapRowDataToAttributes($row)),
-            $this->resource::newModel()
-        );
-
-        return $model;
-    }
-
     public function setResource($resource)
     {
         $this->resource = $resource;