go to matching bracket messes up find next/previous

[pstahle]

It seems once you do a go to matching bracket, it seems to insert the matching bracket into the find next /. previous.

Steps to reproduce:

• do find (ctrl-f) on a search value that has multiple matches (find next/ previous works as expected)
• Place you cursor on a bracket and do a goto to matching bracket
• Now do find next / previous and your bracket will be landed on

A couple of other issues, that I don't know are problems or not:

1. keybourd shortcut shift-F3 for find previous seems not to work on most linux terminals. The only 1 I found that it works on is Kitty
2. The default Ctrl-] seems not to work on every terminal (linux I tried). If I set it using the gui Ctrl-] gets set to Ctrl-5, and both Ctrl-] and Ctrl-5 will work. It seems like for most terminals Ctrl-5 & Ctrl-] are the same scan code. I can't say if this is the case for Mac terminals but all the others I tried including windows putty, windows terminal does the same as the linux terminals.

[sinelaw]

Now do find next / previous and your bracket will be landed on

I can't reproduce this - it just jumps to the next find position (the first one after the cursor's current pos) which is correct

keybourd shortcut shift-F3 for find previous seems not to work on most linux terminals. The only 1 I found that it works on is Kitty

Yup, that's a bug #699 due to an issue in crossterm. Should also work in alacritty, ghostty, and others that support the Kitty protocol. I can't find a workaround at the moment, I should probably select a different shortcut for find prev.

Ctrl+]

Yes, that's also an issue, interpreted as Ctrl+5, need a different shortcut as the default.

[pstahle]

hmmm.... I can reproduce it at will... Maybe something to do with being in a perl script...? Not sure if this will help since you won't be able to see my keystrokes but it might. First time for me using asciinema But here is my cast video on reproducing the problem. Sorry for the unnecessary beginning stuff. Once in fresh I first do the find. Do a couple find next / previous. Then I cursor over and do a matching bracket. Then back to find next/previous. You will see that the bracket replaces the nearest 'sub' that I am searching against.

[pstahle]

Seems like cast file is an unexpected file I can upload... So maybe I can just past it as text... and you can save it...? Anyways I will try that.

[pstahle]

failed to upload my cast file all the ways I tried...

I also am unable to reproduce the problem on my work PC with fedora running in VirtualBox. So maybe this is something specific to one of my PC's, and is not a general issue. I will try to reproduce it later on another PC, and add another comment of my results.....,

[sinelaw]

You can upload a gif

[pstahle]

Am just able to reproduce the problem with this file on multiple PCs. Maybe see if you can reproduce the problem with this:

#!/usr/bin/perl -w

Filename: ogg2mp3

Author: David Ljung Madison <DaveSource.com>

See License: http://MarginalHacks.com/License

Description: Converts ogg to mp3, with artist/title/info

Ideas from: Joseph E. O'Doherty <odoherty.net>

use strict;
use File::Spec;

##################################################

Setup the variables

##################################################
my $PROGNAME = $0;
$PROGNAME =~ s|.*/||;

my $TMPFILE = File::Spec->catfile( File::Spec->tmpdir(), "$PROGNAME.$$.wav" );

#########################

Ogg decoder

Different versions of ogg123 handle files differently! Argh!

If the first doesn't work, try the second..

#########################
#my $OGGDEC = "ogg123 -d wav -o file:$TMPFILE";
my $OGGDEC = "ogg123 -d wav -f $TMPFILE";

#########################

MP3 encoder

Choose your favorite..

#########################
my $MP3ENC = "lame";
#my $MP3ENC = "notlame";

my $OGGINFO = "ogginfo";
my $MP3INFO = "id3tool";

##################################################

Usage

##################################################
sub usage {
foreach my $msg (@_) {
print STDERR "ERROR: $msg\n";
}
print <<USAGE;

Usage:\t$PROGNAME [-d] [-o <dir>] <ogg> ..
\tConverts ogg to mp3
\t-d\tSet debug mode
\t-o\tSpecify output directory

USAGE
exit -1;

}

sub parse_args {
my $outdir;
my @OGGS;
while (my $arg=shift(@argv)) {
if ($arg =~ /^-h$/) { usage(); }
if ($arg =~ /^-d$/) { $MAIN::DEBUG=1; next; }
if ($arg =~ /^-o$/) { $outdir=shift @argv; next; }
if ($arg =~ /^-/) { usage("Unknown option: $arg"); }
push(@OGGS, $arg);
}
usage("No oggs specified") unless @OGGS;

($outdir,@oggs);

}

sub debug {
return unless $MAIN::DEBUG;
foreach my $msg (@_) {
print STDERR "[$PROGNAME] $msg\n";
}
}

##################################################

Genre code

##################################################
my @genres;
open(G,"$MP3INFO -l|") || die("[$PROGNAME] Can't get genre info: [$MP3INFO -l]\n");
while () {
push(@genres,$1) if (/^(\S.*\S)\s+|/);
}
close G;

sub get_genre {
my ($genre) = @_;
return undef unless $genre;
my @g = grep(/^$genre$/i, @genres);
return $g[0] if @g;
@g = grep(/$genre/i, @genres);
print STDERR "[$PROGNAME] Multiple genre matches [$genre -> @g]\n" if $#g>0;
return $g[0] if @g;

# No match
print STDERR "[$PROGNAME] Unknown genre [$genre]\n";
return undef;

}

##################################################

Main code

##################################################
sub ogginfo {
my ($ogg) = @_;

# Get ogg tags
open(TAGS,"$OGGINFO \Q$ogg\E |") || die("[$PROGNAME] Couldn't run ogginfo [$ogg]\n");
my %i;
while(<TAGS>) {
	chomp;
	next if /^\s*$/;

	## The old way:
	#    die("[$PROGNAME] Bad ogginfo: [$_]") unless /^\s*(\S+)=(.*)$/;
	#    $i{$1} .= $2;

	## Old ogginfo:
	## "key=value"
	##
	## New ogginfo:
	## "Some comment stuff..."
	## "    key=value"
	##
	## I suppose I could parse the entire output to see if it's new or
	## old, but it looks like the comments never have '=' in them, and who
	## cares if it does anyways?  So, we'll just use a loose regexp:
	$i{$1} .= $2 if /^\s*(\S+)=(.*)$/;
}
close(TAGS);
\%i;

}

sub set_mp3info {
my ($mp3,$info) = @_;
my $set;
$set .= " -t \Q$info->{title}\E" if $info->{title};
$set .= " -t \Q$info->{TITLE}\E" if $info->{TITLE};
$set .= " -a \Q$info->{album}\E" if $info->{album};
$set .= " -a \Q$info->{ALBUM}\E" if $info->{ALBUM};
$set .= " -r \Q$info->{artist}\E" if $info->{artist};
$set .= " -r \Q$info->{ARTIST}\E" if $info->{ARTIST};
$set .= " -n \Q$info->{comment}\E" if $info->{comment};
$set .= " -n \Q$info->{COMMENT}\E" if $info->{COMMENT};
my $genre = get_genre($info->{genre});
my $genre = get_genre($info->{GENRE});
$set .= " -G \Q$genre\E" if $genre;
$set .= " -y \Q$info->{date}\E" if $info-&gt;{date} =~ /^\d+$/;
$set .= " -y \Q$info->{DATE}\E" if $info-&gt;{DATE} =~ /^\d+$/;
return print STDERR "[$PROGNAME] No tag info for [$mp3]\n" unless $set;
system("$MP3INFO $set \Q$mp3\E");
print STDERR "[$PROGNAME] Errors from:\n $MP3INFO $set $mp3\n $!\n" if $?;
}

sub ogg2mp3 {
my ($outdir,$ogg) = @_;
my $mp3 = $ogg;
$mp3 =~ s/(.ogg)?$/.mp3/i;
return print STDERR "[$PROGNAME] mp3 already exists: [$mp3]\n" if -f $mp3;

# Handle outdir if specified
if ($outdir) {
	$mp3 =~ s|.*/||g;
	$mp3 = "$outdir/$mp3";
}

print "$ogg -> $mp3\n";

# Decode
#  system("$OGGDEC \Q$ogg\E | $MP3ENC - \Q$mp3\E");
#  print STDERR "[$PROGNAME] Errors from:\n  $OGGDEC \Q$ogg\E | $MP3ENC - \Q$mp3\E\n  $!\n"
#    if $?;
system("$OGGDEC \Q$ogg\E");
print STDERR "[$PROGNAME] Errors from:\n  $OGGDEC \Q$ogg\E\n  $!\n" if $?;

# Encode
system("$MP3ENC $TMPFILE \Q$mp3\E");
print STDERR "[$PROGNAME] Errors from:\n  $MP3ENC $TMPFILE \Q$mp3\E\n  $!\n" if $?;
unlink $TMPFILE;

my $info = ogginfo($ogg);
print $info;
set_mp3info($mp3,$info);

}

sub main {
my ($outdir,@OGGS) = parse_args();

map(ogg2mp3($outdir,$_), @oggs);

}
main();