Pass kwargs to json.dumps in singer.format_message #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow configuring json encoder by passing kwargs through to json.dumps in singer.format_message. Use case is passing data from pandas.DataFrame containing NaN to encode as `null`
Contributor
|
Hi @jlujan-omg, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Contributor
|
You did it @jlujan-omg! Thank you for signing the Singer Contribution License Agreement. |
|
When will this be merged, @cmerrick? This is very important as currently (as just one example) anything which needs to write a |
|
The package version updates are unrelated and therefore should be excluded. And a test would be nice to proof that is works + better coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring json encoder by passing kwargs through
to json.dumps in singer.format_message. Use case is passing data
from pandas.DataFrame containing NaN to encode as
null