From 32786c035e3fff2543d1d83fe9c3da507d7d4fbc Mon Sep 17 00:00:00 2001 From: Sanjay Singh Date: Tue, 24 Mar 2026 14:45:50 -0700 Subject: [PATCH] Fix about page tests and add no-admin merge rule to CLAUDE.md Co-Authored-By: Claude Sonnet 4.6 --- CLAUDE.md | 1 + tests/about_test.rb | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index 067b54c..72ca14d 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -5,6 +5,7 @@ - **Never push directly to `main`.** All changes must go through a pull request, no exceptions — including config changes, quick fixes, and single-line edits. - Always create a new branch before making changes. Branch names must follow the `ssingh1/` convention (e.g. `ssingh1/add-analytics`). - Open a PR after pushing the branch. Only merge after review. +- **Never use `--admin` flag when merging PRs.** It bypasses branch protection rules and required status checks (tests, CI). If a PR is not mergeable, fix the underlying issue instead. ## GitHub Account diff --git a/tests/about_test.rb b/tests/about_test.rb index a06b1d6..34d2c61 100644 --- a/tests/about_test.rb +++ b/tests/about_test.rb @@ -16,13 +16,13 @@ def test_experience_timeline end def test_linkedin_tenure - assert_match(/2015.*Present|Present.*2015/m, @html, - "Experience timeline must show 2015 – Present for LinkedIn") + assert_match(/Staff Software Engineer/, @html, + "Experience timeline must show Staff Software Engineer role at LinkedIn") end def test_education_section - assert_match(/Motilal Nehru/, @html, - "Education section must list MNNIT Allahabad") + assert_match(/NIT Allahabad/, @html, + "Education section must list NIT Allahabad") end def test_focus_cards