iOS build fails: `fatal error: 'folly/dynamic.h' file not found`

[mljlynch]

hi, we recently upgraded to singular-react-native to v4.1.0, but now when trying to build we run into:

/Users/Jake/Library/Developer/Xcode/DerivedData/Fig-eyfgvsvskmjhpwggnubkeekcimnn/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/react/bridging/Dynamic.h:10:10: fatal error: 'folly/dynamic.h' file not found
   10 | #include <folly/dynamic.h>

My podfile.lock deletes the RCT-Folly dependency:

  - Singular-React-Native (4.1.0):
-  - RCT-Folly
    - React
    - React-Codegen
    - ReactCommon/turbomodule/core
    - Singular-SDK (= 12.9.0)

Did you remove RCT-Folly as a dependency?

[mljlynch]

Looks like it was removed as part of this PR: 6817f47

[BodySplash]

Hi. Any workaround on that one ? 

[tapasyat]

Hi,
Thank you for your patience while we looked into this issue.
As a workaround, we recommend adding the RCT-Folly dependency to the application's Podfile as shown below:

pod 'RCT-Folly', :podspec => '../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec'

After adding the dependency, please run pod install to ensure the change is applied.
Let us know if this helps resolve the issue.

We will include the fix in next release to prevent the need for this manual step.
We appreciate your understanding.

[BodySplash]

Thanks for your answer. Sadly, given we were on a tight schedule, we had to move to another MMP.
In any case, before switching to another MMP, we've tried a fix similar to your proposal, but then it was missing other react dependencies (debug and timing maybe ? can't remember exactly).
I suspect that the sdk is not compatible with use_frameworks!, which is mandatory for instance if you're using something like react-native-firebase.
Hope that helps.

[matthewdavie]

@tapasyat any update on this? We just ran into the same problem, going to likely have to pivot to AppsFlyer if this isn't a priority.

[tapasyat]

Hi @matthewdavie Sorry for the inconvenience caused. We are actively working on this. We plan to release it ASAP.

In the mean time if this workaround did not work for you #106 (comment)

and we don't want you to be stuck so providing you another workaround. Could you please try this and change the current Singular-React-Native.podspec content with below content. Let us know if this worked for you?

require 'json'
package = JSON.parse(File.read("package.json"))

Pod::Spec.new do |spec|
  spec.name             = "Singular-React-Native"
  spec.version          = package["version"]
  spec.summary          = "Singular React Native bridge for iOS"
  spec.license          = "MIT"
  spec.homepage         = "https://www.singular.net/"
  spec.author           = "Singular Labs"
  spec.source           = { :git => "https://github.com/singular-labs/react-native-sdk.git", :tag => spec.version.to_s }
  # Source files based on architecture
  if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
    spec.source_files = "ios/SingularBridge.h", "ios/SingularBridgeNewArch.mm", "ios/SingularHelper.h", "iOS/SingularHelper.m"
  else
    spec.source_files = "ios/SingularBridge.h", "ios/SingularBridgeOldArch.m", "ios/SingularHelper.h", "iOS/SingularHelper.m"
  end
  spec.platform         = :ios, "12.0"
  spec.dependency 'Singular-SDK', '12.9.0'
  spec.static_framework = true

  if respond_to?(:install_modules_dependencies, true)
    install_modules_dependencies(spec)
  else
    spec.dependency "React"
  end
end

Again we thank you for your patience and understanding!!!

[tapasyat]

Hi all,
Thank you so much for your patience 🙇 We have released new version 4.2.0 with the fix. Let us know how it works for you and if anything else is required! 🙏
Thanks again,
Tapasya