From aa2530e3ef96f3e2a51d8b2d3a82ff45e4c2561e Mon Sep 17 00:00:00 2001 From: Masoud Hedayati Date: Fri, 20 Feb 2026 14:46:31 +0100 Subject: [PATCH 1/3] explicitly mark optional parameters as nullable --- Classes/Controller/ModuleController.php | 2 +- Classes/Controller/SecondaryInspectorController.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/Controller/ModuleController.php b/Classes/Controller/ModuleController.php index 7de94fe..2b5957a 100644 --- a/Classes/Controller/ModuleController.php +++ b/Classes/Controller/ModuleController.php @@ -106,7 +106,7 @@ public function initializeView(ViewInterface $view): void /** * Show an overview of available vocabularies */ - public function indexAction(string $rootNodeAddress = null): void + public function indexAction(?string $rootNodeAddress = null): void { if (is_null($rootNodeAddress)) { $subgraph = $this->taxonomyService->getDefaultSubgraph(); diff --git a/Classes/Controller/SecondaryInspectorController.php b/Classes/Controller/SecondaryInspectorController.php index 92a1f14..c65b45c 100644 --- a/Classes/Controller/SecondaryInspectorController.php +++ b/Classes/Controller/SecondaryInspectorController.php @@ -76,7 +76,7 @@ public function treeAction(string $contextNode, string $startingPoint): void /** * @return mixed[] */ - protected function toJson(Subtree $subtree, string $pathSoFar = null): array + protected function toJson(Subtree $subtree, ?string $pathSoFar = null): array { $label = $this->nodeLabelGenerator->getLabel($subtree->node); $pathSegment = $subtree->node->name?->value ?? $label; From 59f9d17da40d7ec26d7490ac74b8dd29ca8b59fc Mon Sep 17 00:00:00 2001 From: Martin Ficzel Date: Wed, 1 Apr 2026 16:42:24 +0200 Subject: [PATCH 2/3] TASK: Make build green by updating --- .github/workflows/build.yml | 4 +++- composer.json | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b4f3370..866c3da 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -39,4 +39,6 @@ jobs: composer update - name: Run Tests - run: composer test + run: | + composer install + composer lint diff --git a/composer.json b/composer.json index 5c877f2..2a3f995 100644 --- a/composer.json +++ b/composer.json @@ -10,7 +10,7 @@ "neos/fusion-form": ">=2.1.0" }, "require-dev": { - "phpstan/phpstan": "~1.10.16", + "phpstan/phpstan": "~1.12.33", "squizlabs/php_codesniffer": "~3.7.2" }, "autoload": { @@ -27,7 +27,9 @@ "test:lint-fix": ["phpcbf --standard=PSR12 -n Classes"], "test:lint": ["phpcs --standard=PSR12 -n Classes"], "test:stan": ["vendor/bin/phpstan analyse Classes"], - "test": ["composer install", "composer test:lint", "composer test:stan"] + "fix": ["composer test:lint-fix"], + "lint": ["composer test:lint", "composer test:stan"], + "test": ["echo 'not implemented yet'"] }, "config": { "allow-plugins": { From 48cb1633d6b70b26b8e387375df4ec3a6fa32780 Mon Sep 17 00:00:00 2001 From: Martin Ficzel Date: Wed, 1 Apr 2026 16:46:16 +0200 Subject: [PATCH 3/3] TASK: Add php 8.4 + Neos 9.1 to build matrix --- .github/workflows/build.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 866c3da..b017299 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,6 +15,9 @@ jobs: matrix: php-versions: ['8.2', '8.3'] neos-versions: ['9.0'] + include: + - php-versions: '8.4' + neos-versions: '9.1' runs-on: ubuntu-latest