fixed: null-terminated strings

Author: sivar2311

examples/Settings/MultiWiFi/SinricProWiFiSettings.cpp

@@ -18,8 +18,8 @@ void SinricProWiFiSettings::begin() {
 
 void SinricProWiFiSettings::updatePrimarySettings(const char* newSSID, const char* newPassword) {
   if (isValidSetting(newSSID, newPassword)) {
-    strncpy(wifiSettings.primarySSID, newSSID, sizeof(wifiSettings.primarySSID));
-    strncpy(wifiSettings.primaryPassword, newPassword, sizeof(wifiSettings.primaryPassword));
+    strlcpy(wifiSettings.primarySSID, newSSID, sizeof(wifiSettings.primarySSID));
+    strlcpy(wifiSettings.primaryPassword, newPassword, sizeof(wifiSettings.primaryPassword));
     saveToFile();
   } else {
     Serial.println("Invalid Primary SSID or Password");
@@ -28,8 +28,8 @@ void SinricProWiFiSettings::updatePrimarySettings(const char* newSSID, const cha
 
 void SinricProWiFiSettings::updateSecondarySettings(const char* newSSID, const char* newPassword) {
   if (isValidSetting(newSSID, newPassword)) {
-    strncpy(wifiSettings.secondarySSID, newSSID, sizeof(wifiSettings.secondarySSID));
-    strncpy(wifiSettings.secondaryPassword, newPassword, sizeof(wifiSettings.secondaryPassword));
+    strlcpy(wifiSettings.secondarySSID, newSSID, sizeof(wifiSettings.secondarySSID));
+    strlcpy(wifiSettings.secondaryPassword, newPassword, sizeof(wifiSettings.secondaryPassword));
     saveToFile();
   } else {
     Serial.println("Invalid Secondary SSID or Password");
@@ -75,10 +75,10 @@ bool SinricProWiFiSettings::loadFromFile() {
 void SinricProWiFiSettings::saveDefaultSettings() {
   Serial.println("Saving default WiFi login!");
 
-  strncpy(wifiSettings.primarySSID, defaultPrimarySSID, sizeof(wifiSettings.primarySSID));
-  strncpy(wifiSettings.primaryPassword, defaultPrimaryPassword, sizeof(wifiSettings.primaryPassword));
-  strncpy(wifiSettings.secondarySSID, defaultSecondarySSID, sizeof(wifiSettings.secondarySSID));
-  strncpy(wifiSettings.secondaryPassword, defaultSecondaryPassword, sizeof(wifiSettings.secondaryPassword));
+  strlcpy(wifiSettings.primarySSID, defaultPrimarySSID, sizeof(wifiSettings.primarySSID));
+  strlcpy(wifiSettings.primaryPassword, defaultPrimaryPassword, sizeof(wifiSettings.primaryPassword));
+  strlcpy(wifiSettings.secondarySSID, defaultSecondarySSID, sizeof(wifiSettings.secondarySSID));
+  strlcpy(wifiSettings.secondaryPassword, defaultSecondaryPassword, sizeof(wifiSettings.secondaryPassword));
 
   saveToFile();
 }

examples/Settings/MultiWiFi/SinricProWiFiSettings.h

@@ -11,10 +11,10 @@
 class SinricProWiFiSettings {
 public:
   struct wifi_settings_t {
-    char primarySSID[32];        ///< Primary SSID of the WiFi network.
-    char primaryPassword[64];    ///< Primary password of the WiFi network.
-    char secondarySSID[32];      ///< Secondary SSID of the WiFi network.
-    char secondaryPassword[64];  ///< Secondary password of the WiFi network.
+    char primarySSID[32+1];        ///< Primary SSID of the WiFi network.
+    char primaryPassword[64+1];    ///< Primary password of the WiFi network.
+    char secondarySSID[32+1];      ///< Secondary SSID of the WiFi network.
+    char secondaryPassword[64+1];  ///< Secondary password of the WiFi network.
   };
 
   /**