✅ Brings test coverage back up to 100%

Author: skellock

package.json

@@ -129,12 +129,13 @@
       "json"
     ],
     "coveragePathIgnorePatterns": [
-      "/node_modules/",
-      "/out/",
-      "/build/",
-      "/dist/",
-      "/test/",
-      "/docs/"
+      "./node_modules",
+      "./out",
+      "./build",
+      "./dist",
+      "./test",
+      "./docs",
+      "\\.story.tsx$"
     ],
     "coverageThreshold": {
       "global": {

src/renderer/features/example-using-tabs/welcome-screen/sample-tabs.tsx

@@ -19,9 +19,9 @@ export interface SampleTabsProps {
   onChangeTab: (tab: SampleTabType) => void
 }
 
-const KEY_1 = `${commandOrControlKey}+1`
-const KEY_2 = `${commandOrControlKey}+2`
-const KEY_3 = `${commandOrControlKey}+3`
+const KEY_1 = `${commandOrControlKey()}+1`
+const KEY_2 = `${commandOrControlKey()}+2`
+const KEY_3 = `${commandOrControlKey()}+3`
 
 // an extra layer just for the drag style due to electron bug
 const ROOT = css(styles.windowDrag)

src/renderer/platform/components/centered-content/centered-content.story.tsx

@@ -0,0 +1,15 @@
+import * as React from 'react'
+import { StorybookStory as Story, StorybookGroup as Group } from '../storybook'
+import { storiesOf } from '@storybook/react'
+import { CenteredContent } from './index'
+
+storiesOf('CenteredContent', module).add('default', () => (
+  <Story>
+    <Group title='default'>
+      <CenteredContent>
+        <p>i am in the middle</p>
+        <p>i am also a really strange component and shouldn't exist.</p>
+      </CenteredContent>
+    </Group>
+  </Story>
+))

src/renderer/platform/components/enter-animation/enter-animation.story.tsx

@@ -0,0 +1,21 @@
+import * as React from 'react'
+import { StorybookStory as Story, StorybookGroup as Group } from '../storybook'
+
+import { storiesOf } from '@storybook/react'
+import { EnterAnimation } from './index'
+// import { Value } from 'react-powerplug'
+
+storiesOf('EnterAnimation', module).add('default', () => (
+  <Story>
+    <Group title='grow'>
+      <EnterAnimation animation='grow'>
+        <p>hi</p>
+      </EnterAnimation>
+    </Group>
+    <Group title='slide'>
+      <EnterAnimation animation='slide'>
+        <p>hi</p>
+      </EnterAnimation>
+    </Group>
+  </Story>
+))

src/renderer/platform/components/enter-animation/enter-animation.tsx

@@ -28,6 +28,7 @@ const FINISH = cssProps({ transform: `translate(0, 0) scale(1, 1)` })
 export class EnterAnimation extends React.Component<EnterAnimationProps, EnterAnimationState> {
   state: EnterAnimationState = {}
 
+  // istanbul ignore next
   componentDidMount() {
     setTimeout(() => this.setState({ mounted: true }), 1)
   }
@@ -55,6 +56,7 @@ export class EnterAnimation extends React.Component<EnterAnimationProps, EnterAn
 
     // style props
     const starting = css(cssProps({ transform, transition }))
+    // istanbul ignore next
     const finishing = css(mounted && FINISH)
 
     return (

src/renderer/platform/components/scrollable-content/scrollable-content.story.tsx

@@ -0,0 +1,25 @@
+import * as React from 'react'
+import { StorybookStory as Story, StorybookGroup as Group } from '../storybook'
+import { storiesOf } from '@storybook/react'
+import { ScrollableContent } from './index'
+
+storiesOf('ScrollableContent', module).add('default', () => (
+  <Story>
+    <Group title='default'>
+      <ScrollableContent style={{ height: 100 }}>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+        <p>hi</p>
+      </ScrollableContent>
+    </Group>
+  </Story>
+))

src/renderer/platform/components/spin-animation/spin-animation-state.test.ts

@@ -10,8 +10,15 @@ test('next', () => {
 
 test('createSpinStates', () => {
   const states = createSpinStates({})
+  expect(typeof states.forward).toBe('function')
   expect(typeof states.back).toBe('function')
 
+  const forwardResults = states.forward({ value: { get: () => 1 } })
+  expect(forwardResults.current).toBe(1)
+
+  const backResults = states.back({ value: { get: () => 1 } })
+  expect(backResults.current).toBe(1)
+
   const value: any = () => {}
   value.get = () => 1
   value.previousState = 'back'

src/renderer/platform/components/tab/tab.story.tsx

@@ -0,0 +1,23 @@
+import * as React from 'react'
+import { StorybookStory as Story, StorybookGroup as Group } from '../storybook'
+
+import { storiesOf } from '@storybook/react'
+import { Tab } from './index'
+import { Value } from 'react-powerplug'
+
+storiesOf('Tab', module).add('Tab', () => (
+  <Story>
+    <Group title='inactive'>
+      <Value initial='three'>
+        {({ value, setValue }) => (
+          <div style={{ flexDirection: 'row', display: 'flex' }}>
+            <Tab text='One' active={value === 'one'} onClick={() => setValue('one')} />
+            <Tab text='Two' active={value === 'two'} onClick={() => setValue('two')} />
+            <Tab text='Three' active={value === 'three'} onClick={() => setValue('three')} />
+            <Tab text='Four' active={value === 'four'} onClick={() => setValue('four')} />
+          </div>
+        )}
+      </Value>
+    </Group>
+  </Story>
+))

src/renderer/platform/components/text/text.story.tsx

@@ -6,13 +6,17 @@ import { storiesOf } from '@storybook/react'
 import { Text } from './index'
 
 storiesOf('Text', module)
-  .add('text styles', () =>
+  .add('text styles', () => (
     <Story>
       <Group title='regular text'>
         <Text>Hello World!</Text>
         <Text>$123.45</Text>
         <Text>The quick brown fox jumped over the slow lazy dog.</Text>
       </Group>
+      <Group title='with text property'>
+        <Text text='Passed in text property' />
+      </Group>
+
       <Group title='huge paragraph'>
         <Text>
           Wayfarers intelligentsia salvia sartorial keffiyeh locavore direct trade flexitarian
@@ -45,9 +49,9 @@ storiesOf('Text', module)
       <Group title='style={{ color: &quot;red&quot; }}'>
         <Text style={{ color: 'red' }}>Hello World!</Text>
       </Group>
-    </Story>,
-  )
-  .add('with nested children', () =>
+    </Story>
+  ))
+  .add('with nested children', () => (
     <Story>
       <Group title='with nested children'>
         <Text>
@@ -62,5 +66,5 @@ storiesOf('Text', module)
           </p>
         </Text>
       </Group>
-    </Story>,
-  )
+    </Story>
+  ))

src/renderer/platform/utils/keyboard/keyboard.test.ts

@@ -11,7 +11,6 @@ jest.mock('../../../../shared', () => {
 })
 
 import * as Mousetrap from 'mousetrap'
-// import * as platform from '../../../../shared/utils/platform/platform'
 
 test('changes tabs', () => {
   const fn = () => true
@@ -25,13 +24,13 @@ test('changes tabs', () => {
 
 test('mac is command key', () => {
   const { commandOrControlKey } = require('./keyboard')
-  expect(commandOrControlKey).toBe('command')
+  expect(commandOrControlKey()).toBe('command')
 })
 
 test('non-mac is control', () => {
-  jest.resetModules()
+  // jest.resetModules()
   const shared = require('../../../../shared')
   shared.isMac = jest.fn().mockReturnValue(false)
   const { commandOrControlKey } = require('./keyboard')
-  expect(commandOrControlKey).toBe('ctrl')
+  expect(commandOrControlKey()).toBe('ctrl')
 })