Merge pull request #104 from skellock/stricter-ts

🔨 Adds stricter type checking and linting.

Author: skellock

package.json

@@ -108,6 +108,7 @@
     "ts-loader": "^3.2.0",
     "ts-node": "^3.3.0",
     "tslint": "^5.8.0",
+    "tslint-config-prettier": "^1.6.0",
     "typescript": "~2.6.2"
   },
   "jest": {

src/main/main-window/main-window.test.ts

@@ -1,4 +1,5 @@
 import { createMainWindow } from './main-window'
+// @ts-ignore
 import * as containDeep from 'jest-expect-contain-deep'
 import { BrowserWindow } from 'electron'
 const WindowStateManager = require('electron-window-state-manager')

src/renderer/platform/components/tab/tab.story.tsx

@@ -1,22 +1,25 @@
 import * as React from 'react'
 import { StorybookStory as Story, StorybookGroup as Group } from '../storybook'
-
 import { storiesOf } from '@storybook/react'
 import { Tab } from './index'
+// @ts-ignore
 import { Value } from 'react-powerplug'
 
 storiesOf('Tab', module).add('Tab', () => (
   <Story>
     <Group title='inactive'>
       <Value initial='three'>
-        {({ value, setValue }) => (
-          <div style={{ flexDirection: 'row', display: 'flex' }}>
-            <Tab text='One' active={value === 'one'} onClick={() => setValue('one')} />
-            <Tab text='Two' active={value === 'two'} onClick={() => setValue('two')} />
-            <Tab text='Three' active={value === 'three'} onClick={() => setValue('three')} />
-            <Tab text='Four' active={value === 'four'} onClick={() => setValue('four')} />
-          </div>
-        )}
+        {(arg: any) => {
+          const { value, setValue } = arg
+          return (
+            <div style={{ flexDirection: 'row', display: 'flex' }}>
+              <Tab text='One' active={value === 'one'} onClick={() => setValue('one')} />
+              <Tab text='Two' active={value === 'two'} onClick={() => setValue('two')} />
+              <Tab text='Three' active={value === 'three'} onClick={() => setValue('three')} />
+              <Tab text='Four' active={value === 'four'} onClick={() => setValue('four')} />
+            </div>
+          )
+        }}
       </Value>
     </Group>
   </Story>

tsconfig.json

@@ -6,13 +6,11 @@
     "jsx": "react",
     "experimentalDecorators": true,
     "allowSyntheticDefaultImports": false,
-    "strict": false,
     "noUnusedLocals": true,
-    "inlineSourceMap": true
+    "inlineSourceMap": true,
+    "strictNullChecks": true,
+    "noImplicitReturns": true,
+    "noImplicitAny": true
   },
-  "include": [
-    "src",
-    "typings",
-    "fuse.ts"
-  ]
+  "include": ["src", "typings", "fuse.ts"]
 }

tslint.json

@@ -1,4 +1,5 @@
 {
+  "extends": "tslint-config-prettier",
   "rules": {
     "ordered-imports": [false],
     "quotemark": [true, "single", "jsx-single", "avoid-escape"],

yarn.lock

@@ -7338,6 +7338,10 @@ tslib@^1.7.1:
   version "1.8.1"
   resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.8.1.tgz#6946af2d1d651a7b1863b531d6e5afa41aa44eac"
 
+tslint-config-prettier@^1.6.0:
+  version "1.6.0"
+  resolved "https://registry.yarnpkg.com/tslint-config-prettier/-/tslint-config-prettier-1.6.0.tgz#fec1ee8fb07e8f033c63fed6b135af997f31962a"
+
 tslint@^5.8.0:
   version "5.8.0"
   resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.8.0.tgz#1f49ad5b2e77c76c3af4ddcae552ae4e3612eb13"