Stricter type-checking

Author: skirtles-code

package.json

@@ -8,19 +8,25 @@
   "devDependencies": {
     "@eslint/compat": "^1.2.6",
     "@stylistic/eslint-plugin": "^4.0.0",
+    "@tsconfig/node22": "^22.0.0",
+    "@types/node": "^22.13.0",
     "@typescript-eslint/parser": "^8.23.0",
     "@vue/eslint-config-typescript": "^14.3.0",
     "eslint": "^9.18.0",
     "eslint-plugin-vue": "^9.32.0",
     "jiti": "^2.4.2",
     "lint-staged": "^15.4.3",
-    "simple-git-hooks": "^2.11.1"
+    "npm-run-all2": "^7.0.2",
+    "simple-git-hooks": "^2.11.1",
+    "typescript": "^5.7.3"
   },
   "scripts": {
     "clean": "pnpm run -r clean",
     "docs:dev": "pnpm run --filter ./packages/docs -r dev",
     "docs:build": "pnpm run --filter ./packages/docs -r build",
-    "type-check": "pnpm run -r type-check",
+    "type-check": "run-p type-check:*",
+    "type-check:packages": "pnpm run -r type-check",
+    "type-check:self": "tsc",
     "lint": "eslint",
     "lint:fix": "eslint --fix",
     "build": "pnpm run -r build",

packages/create-vue-lib/package.json

@@ -38,10 +38,10 @@
   },
   "scripts": {
     "clean": "rimraf dist",
-    "build": "run-s clean build:copy build:ts",
+    "type-check": "tsc",
     "build:copy": "copyfiles -u 1 -a \"src/template/**\" dist",
     "build:ts": "tsup src/index.ts --format cjs --target node18",
-    "build:dts": "tsup src/index.ts --dts --format cjs --target node18",
+    "build": "run-s clean build:copy build:ts",
     "start": "node ./dist/index.cjs",
     "preinstall": "npx only-allow pnpm"
   }

packages/create-vue-lib/src/index.ts

@@ -24,7 +24,7 @@ async function prompt(options: Omit<PromptObject, 'name'>) {
     return result.name
   }
   catch (cancelled) {
-    console.log(cancelled.message)
+    console.log((cancelled as { message: string }).message)
     process.exit(1)
   }
 }
@@ -103,7 +103,7 @@ Full documentation at https://skirtles-code.github.io/create-vue-lib/
 `
 
 function processArgs(): Args {
-  let argValues: object = {}
+  let argValues: { help?: boolean, version?: boolean, extended?: boolean } = {}
 
   const options = {
     extended: {
@@ -128,9 +128,9 @@ function processArgs(): Args {
     argValues = args.values
   }
   catch (err) {
-    if (err.code === 'ERR_PARSE_ARGS_UNKNOWN_OPTION') {
+    if ((err as { code: string }).code === 'ERR_PARSE_ARGS_UNKNOWN_OPTION') {
       console.log('Error:')
-      console.log(err.message)
+      console.log((err as { message: string }).message)
       console.log('See --help for valid options')
       process.exit(1)
     }
@@ -154,7 +154,7 @@ function processArgs(): Args {
   }
 }
 
-function isValidPackageName(packageName) {
+function isValidPackageName(packageName: string) {
   // This is a bit stricter than npm requires, but we use the package name
   // to generate various other things, like directory names and the global
   // variable name, so we insist on having a 'safe' first character.
@@ -408,7 +408,7 @@ function copyFiles(templateFile: string, config: Config) {
     const template = fs.readFileSync(templatePath, 'utf-8')
     const content = template
       .replace(/@projectName@/g, config.mainPackageDirName)
-      .replace(new RegExp(`@(${Object.keys(config).join('|')})@`, 'g'), (all, setting) => config[setting] ?? all)
+      .replace(new RegExp(`@(${Object.keys(config).join('|')})@`, 'g'), (all, setting) => `${config[setting as keyof Config] ?? all}`)
 
     fs.writeFileSync(targetPath, content)
   }

packages/create-vue-lib/tsconfig.json

@@ -2,9 +2,9 @@
   "extends": "@tsconfig/node22/tsconfig.json",
   "include": ["src/index.ts"],
   "compilerOptions": {
-    "strict": false,
-    "resolveJsonModule": true,
+    "noEmit": true,
+    "module": "ESNext",
     "moduleResolution": "Bundler",
-    "module": "ESNext"
+    "types": ["node"]
   }
 }

pnpm-lock.yaml

@@ -1,4 +1,10 @@
 {
-  "files": ["eslint.config.mts"],
-  "include": ["scripts/**/*"]
+  "extends": "@tsconfig/node22/tsconfig.json",
+  "include": ["eslint.config.*"],
+  "compilerOptions": {
+    "noEmit": true,
+    "module": "ESNext",
+    "moduleResolution": "Bundler",
+    "types": ["node"]
+  }
 }