Skip to content

Commit 3a936c3

Browse files
Add TODO item about frame rotation intelligence
1 parent a2488ff commit 3a936c3

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

skyfield/sgp4lib.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,10 @@ def _position_and_velocity_TEME_km(self, t):
170170

171171
def ITRF_position_velocity_error(self, t):
172172
"""Deprecated: use the TEME and ITRS frame objects instead."""
173+
# TODO: can we teach frame objects to figure out that the
174+
# transform TEME -> ITRS can not only skip the t.M rotation, but
175+
# can also subtract the angles of their two competing z-axis
176+
# rotations and call rot_z() only once instead of twice?
173177
rTEME, vTEME, error = self._position_and_velocity_TEME_km(t)
174178
rTEME /= AU_KM
175179
vTEME /= AU_KM

0 commit comments

Comments
 (0)