From a87561b40c3980636a92af590f07630e3c2b0cc0 Mon Sep 17 00:00:00 2001 From: Michael Brooks Date: Thu, 12 Mar 2026 15:25:34 -0700 Subject: [PATCH] feat: default manifest source to local for non-Deno apps Change the default manifest source for non-Deno (Bolt) projects from ManifestSourceRemote to ManifestSourceLocal, aligning their behavior with Deno projects. --- cmd/project/init.go | 1 - internal/pkg/create/create.go | 4 ++-- internal/pkg/create/create_test.go | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/cmd/project/init.go b/cmd/project/init.go index 946663d0..cd062abf 100644 --- a/cmd/project/init.go +++ b/cmd/project/init.go @@ -108,7 +108,6 @@ func projectInitCommandRunE(clients *shared.ClientFactory, cmd *cobra.Command, a // Install the project dependencies, such as .slack/ and runtime packages // Existing projects initialized always default to config.ManifestSourceLocal. - // The link command will switch it to config.ManifestSourceRemote _ = create.InstallProjectDependencies(ctx, clients, projectDirPath, config.ManifestSourceLocal) // Add an existing app to the project diff --git a/internal/pkg/create/create.go b/internal/pkg/create/create.go index 09a85b7e..1ec3e11c 100644 --- a/internal/pkg/create/create.go +++ b/internal/pkg/create/create.go @@ -521,12 +521,12 @@ func InstallProjectDependencies( manifestSource = config.ManifestSourceLocal } - // Set non-Deno (non-ROSI) projects to ManifestSourceRemote. + // Set non-Deno (non-ROSI) projects to ManifestSourceLocal. // TODO: should check if Slack hosted project, but the SDKConfig has not been initialized yet. if clients.Runtime != nil { isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno") if !isDenoProject { - manifestSource = config.ManifestSourceRemote + manifestSource = config.ManifestSourceLocal } } diff --git a/internal/pkg/create/create_test.go b/internal/pkg/create/create_test.go index 2e8c561e..5dbb3560 100644 --- a/internal/pkg/create/create_test.go +++ b/internal/pkg/create/create_test.go @@ -432,10 +432,10 @@ func Test_Create_installProjectDependencies(t *testing.T) { `Updated config.json manifest source to "project" (local)`, }, }, - "When non-Deno project, should set manifest source to app settings (remote)": { + "When non-Deno project, should set manifest source to project (local)": { runtime: "node", expectedOutputs: []string{ - `Updated config.json manifest source to "app settings" (remote)`, + `Updated config.json manifest source to "project" (local)`, }, }, }